Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: Source/core/style/StyleRareNonInheritedData.h

Issue 1070143002: [Alignment] Single class for holding the alignment data. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased and got back previous setter names. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/style/StyleContentAlignmentData.h ('k') | Source/core/style/StyleRareNonInheritedData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/style/StyleRareNonInheritedData.h
diff --git a/Source/core/style/StyleRareNonInheritedData.h b/Source/core/style/StyleRareNonInheritedData.h
index d801f05d751ab7f1295cb9a291b07caf1631225c..70842491bbf0d8fc400ecf64843bd7d1a152ec3b 100644
--- a/Source/core/style/StyleRareNonInheritedData.h
+++ b/Source/core/style/StyleRareNonInheritedData.h
@@ -37,6 +37,8 @@
#include "core/style/LineClampValue.h"
#include "core/style/NinePieceImage.h"
#include "core/style/ShapeValue.h"
+#include "core/style/StyleContentAlignmentData.h"
+#include "core/style/StyleSelfAlignmentData.h"
#include "platform/LengthPoint.h"
#include "wtf/OwnPtr.h"
#include "wtf/PassRefPtr.h"
@@ -145,21 +147,17 @@ public:
Vector<String> m_callbackSelectors;
+ StyleContentAlignmentData m_alignContent;
+ StyleSelfAlignmentData m_alignItems;
+ StyleSelfAlignmentData m_alignSelf;
+ StyleContentAlignmentData m_justifyContent;
+ StyleSelfAlignmentData m_justifyItems;
+ StyleSelfAlignmentData m_justifySelf;
+
unsigned m_pageSizeType : 2; // PageSizeType
unsigned m_transformStyle3D : 1; // ETransformStyle3D
unsigned m_backfaceVisibility : 1; // EBackfaceVisibility
- unsigned m_alignContent : 4; // ContentPosition
- unsigned m_alignContentDistribution : 3; // ContentDistributionType
- unsigned m_alignContentOverflowAlignment : 2; // OverflowAlignment
- unsigned m_alignItems : 4; // ItemPosition
- unsigned m_alignItemsOverflowAlignment : 2; // OverflowAlignment
- unsigned m_alignSelf : 4; // ItemPosition
- unsigned m_alignSelfOverflowAlignment : 2; // OverflowAlignment
- unsigned m_justifyContent : 4; // ContentPosition
- unsigned m_justifyContentDistribution : 3; // ContentDistributionType
- unsigned m_justifyContentOverflowAlignment : 2; // OverflowAlignment
-
unsigned userDrag : 2; // EUserDrag
unsigned textOverflow : 1; // Whether or not lines that spill out should be truncated with "..."
unsigned marginBeforeCollapse : 2; // EMarginCollapse
@@ -186,13 +184,6 @@ public:
unsigned m_isolation : 1; // Isolation
- unsigned m_justifyItems : 4; // ItemPosition
- unsigned m_justifyItemsOverflowAlignment : 2; // OverflowAlignment
- unsigned m_justifyItemsPositionType: 1; // Whether or not alignment uses the 'legacy' keyword.
-
- unsigned m_justifySelf : 4; // ItemPosition
- unsigned m_justifySelfOverflowAlignment : 2; // OverflowAlignment
-
// ScrollBehavior. 'scroll-behavior' has 2 accepted values, but ScrollBehavior has a third
// value (that can only be specified using CSSOM scroll APIs) so 2 bits are needed.
unsigned m_scrollBehavior: 2;
« no previous file with comments | « Source/core/style/StyleContentAlignmentData.h ('k') | Source/core/style/StyleRareNonInheritedData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698