Source/core/css/resolver/StyleBuilderConverter.h - Issue 1070143002: [Alignment] Single class for holding the alignment data.

Side by Side Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 1070143002: [Alignment] Single class for holding the alignment data. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Using the StyleConverter. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/css/resolver/StyleAdjuster.cpp ('k') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * * Redistributions of source code must retain the above copyright	4 * * Redistributions of source code must retain the above copyright

5 * notice, this list of conditions and the following disclaimer.	5 * notice, this list of conditions and the following disclaimer.

6 * * Redistributions in binary form must reproduce the above	6 * * Redistributions in binary form must reproduce the above

7 * copyright notice, this list of conditions and the following disclaimer	7 * copyright notice, this list of conditions and the following disclaimer

8 * in the documentation and/or other materials provided with the	8 * in the documentation and/or other materials provided with the

9 * distribution.	9 * distribution.

10 * * Neither the name of Google Inc. nor the names of its	10 * * Neither the name of Google Inc. nor the names of its

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 template <typename T> static T convertComputedLength(StyleResolverState&, CS SValue*);	51 template <typename T> static T convertComputedLength(StyleResolverState&, CS SValue*);

52 static LengthBox convertClip(StyleResolverState&, CSSValue*);	52 static LengthBox convertClip(StyleResolverState&, CSSValue*);

53 template <typename T> static T convertFlags(StyleResolverState&, CSSValue*);	53 template <typename T> static T convertFlags(StyleResolverState&, CSSValue*);

54 static FontDescription::FamilyDescription convertFontFamily(StyleResolverSta te&, CSSValue*);	54 static FontDescription::FamilyDescription convertFontFamily(StyleResolverSta te&, CSSValue*);

55 static PassRefPtr<FontFeatureSettings> convertFontFeatureSettings(StyleResol verState&, CSSValue*);	55 static PassRefPtr<FontFeatureSettings> convertFontFeatureSettings(StyleResol verState&, CSSValue*);

56 static FontDescription::Size convertFontSize(StyleResolverState&, CSSValue*) ;	56 static FontDescription::Size convertFontSize(StyleResolverState&, CSSValue*) ;

57 static float convertFontSizeAdjust(StyleResolverState&, CSSValue*);	57 static float convertFontSizeAdjust(StyleResolverState&, CSSValue*);

58 static FontWeight convertFontWeight(StyleResolverState&, CSSValue*);	58 static FontWeight convertFontWeight(StyleResolverState&, CSSValue*);

59 static FontDescription::VariantLigatures convertFontVariantLigatures(StyleRe solverState&, CSSValue*);	59 static FontDescription::VariantLigatures convertFontVariantLigatures(StyleRe solverState&, CSSValue*);

60 static EGlyphOrientation convertGlyphOrientation(StyleResolverState&, CSSVal ue*);	60 static EGlyphOrientation convertGlyphOrientation(StyleResolverState&, CSSVal ue*);

	61 static StyleAlignmentData convertSelfAlignmentData(StyleResolverState&, CSSV alue*);
	Julien - ping for review 2015/04/13 14:46:20 This name doesn't really reflect the callers as it This name doesn't really reflect the callers as it's called for both -self and -items properties. jfernandez 2015/04/14 00:18:42 Ok, that's true. f we want to use the ComputedStyl Show quoted text On 2015/04/13 14:46:20, Julien - OOO 18 Apr - 14 May wrote: > This name doesn't really reflect the callers as it's called for both -self and > -items properties. Ok, that's true. f we want to use the ComputedStyle initial value functions I'll have to define a converter function for each property, which is probably a better idea.
	62 static StyleAlignmentData convertContentAlignmentData(StyleResolverState&, C SSValue*);

61 static GridAutoFlow convertGridAutoFlow(StyleResolverState&, CSSValue*);	63 static GridAutoFlow convertGridAutoFlow(StyleResolverState&, CSSValue*);

62 static GridPosition convertGridPosition(StyleResolverState&, CSSValue*);	64 static GridPosition convertGridPosition(StyleResolverState&, CSSValue*);

63 static GridTrackSize convertGridTrackSize(StyleResolverState&, CSSValue*);	65 static GridTrackSize convertGridTrackSize(StyleResolverState&, CSSValue*);

64 template <typename T> static T convertLineWidth(StyleResolverState&, CSSValu e*);	66 template <typename T> static T convertLineWidth(StyleResolverState&, CSSValu e*);

65 static Length convertLength(const StyleResolverState&, CSSValue*);	67 static Length convertLength(const StyleResolverState&, CSSValue*);

66 static UnzoomedLength convertUnzoomedLength(const StyleResolverState&, CSSVa lue*);	68 static UnzoomedLength convertUnzoomedLength(const StyleResolverState&, CSSVa lue*);

67 static Length convertLengthOrAuto(const StyleResolverState&, CSSValue*);	69 static Length convertLengthOrAuto(const StyleResolverState&, CSSValue*);

68 static Length convertLengthSizing(StyleResolverState&, CSSValue*);	70 static Length convertLengthSizing(StyleResolverState&, CSSValue*);

69 static Length convertLengthMaxSizing(StyleResolverState&, CSSValue*);	71 static Length convertLengthMaxSizing(StyleResolverState&, CSSValue*);

70 static TabSize convertLengthOrTabSpaces(StyleResolverState&, CSSValue*);	72 static TabSize convertLengthOrTabSpaces(StyleResolverState&, CSSValue*);

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
141 {	143 {

142 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);	144 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

143 if (primitiveValue->getValueID() == IdForNone)	145 if (primitiveValue->getValueID() == IdForNone)

144 return nullAtom;	146 return nullAtom;

145 return AtomicString(primitiveValue->getStringValue());	147 return AtomicString(primitiveValue->getStringValue());

146 }	148 }

147	149

148 } // namespace blink	150 } // namespace blink

149	151

150 #endif	152 #endif

OLD	NEW