Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: Source/core/style/StyleAlignmentData.h

Issue 1070143002: [Alignment] Single class for holding the alignment data. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/style/ComputedStyle.cpp ('k') | Source/core/style/StyleAlignmentData.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef StyleAlignmentData_h
6 #define StyleAlignmentData_h
7
8 #include "core/style/ComputedStyleConstants.h"
9
10 namespace blink {
11
12 class StyleAlignmentData {
13 public:
14 StyleAlignmentData(ItemPosition, OverflowAlignment, ItemPositionType = NonLe gacyPosition);
15 StyleAlignmentData(ContentPosition, ContentDistributionType, OverflowAlignme nt);
Julien - ping for review 2015/04/09 15:23:20 I would love a class comment to explain these cons
jfernandez 2015/04/09 15:55:55 Done.
16 StyleAlignmentData(const StyleAlignmentData&);
17
18 bool operator==(const StyleAlignmentData& o) const
19 {
20 return m_itemPosition == o.m_itemPosition && m_contentPosition == o.m_co ntentPosition && m_distribution == o.m_distribution && m_positionType == o.m_pos itionType && m_overflow == o.m_overflow && m_positionType == o.m_positionType;
Julien - ping for review 2015/04/09 15:23:20 Nit: This doesn't follow the order below (m_positi
jfernandez 2015/04/09 15:55:55 Done.
21 }
22
23 bool operator!=(const StyleAlignmentData& o) const
24 {
25 return !(*this == o);
26 }
27
28 ItemPosition m_itemPosition;
29 ContentPosition m_contentPosition;
30 ContentDistributionType m_distribution;
31 ItemPositionType m_positionType;
32 OverflowAlignment m_overflow;
33 };
34
35 } // namespace blink
36
37 #endif // StyleAlignmentData_h
OLDNEW
« no previous file with comments | « Source/core/style/ComputedStyle.cpp ('k') | Source/core/style/StyleAlignmentData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698