src/ia32/macro-assembler-ia32.cc - Issue 10701054: Enable stub generation using Hydrogen/Lithium (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 10701054: Enable stub generation using Hydrogen/Lithium (again) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 41c8667f1c726224776f18f5d2678f453ce76189..065aca77ada3018fee4d159d5d88eab8595964e9 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -1801,7 +1801,9 @@ void MacroAssembler::CallRuntimeSaveDoubles(Runtime::FunctionId id) {

const Runtime::Function* function = Runtime::FunctionForId(id);

Set(eax, Immediate(function->nargs));

mov(ebx, Immediate(ExternalReference(function, isolate())));

- CEntryStub ces(1, kSaveFPRegs);

+ CEntryStub ces(1, CpuFeatures::IsSupported(SSE2)

Jakob Kummerow 2012/11/28 16:28:22 nit: indentation / line break. CEntryStub ces(1,

danno 2012/11/30 16:23:24 Done.

+ ? kSaveFPRegs :

+ kDontSaveFPRegs);

CallStub(&ces);

}