net: Implement canceling of all async operations in FileStream.

chromeos/dbus/debug_daemon_client.cc

Index: chromeos/dbus/debug_daemon_client.cc
diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc
index 05d3b394ddce75695455ce808f9ccd1209c04f3f..f129e66a80a8fd791d412229931773c6672fac5e 100644
--- a/chromeos/dbus/debug_daemon_client.cc
+++ b/chromeos/dbus/debug_daemon_client.cc
@@ -52,7 +52,7 @@ class PipeReader {
 
   virtual ~PipeReader() {
     if (pipe_fd_[0] != -1)
-      if (HANDLE_EINTR(close(pipe_fd_[0])) < 0)
+      if (!data_stream_.get() && HANDLE_EINTR(close(pipe_fd_[0])) < 0)
         PLOG(ERROR) << "close[0]";

[satorux1, 2012/11/05 03:18:35]

Can we remove the line 54-56?

pipe_fd_[0] is closed by data_stream_, right? Maybe we should leave a comment
like:

// Don't close pipe_fd_[0] as it's closed by data_stream_.

[pivanof, 2012/11/05 05:17:46]

For some reason I thought that there can be situations when pipe_fd_[0] is not
bound to data_stream_, i.e. pipe_fd_ exists but data_stream_ doesn't. Looking at
the code now I see that it's impossible, so indeed I removed these lines.

     if (pipe_fd_[1] != -1)
       if (HANDLE_EINTR(close(pipe_fd_[1])) < 0)