Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1070093002: Eagerly escape RegExp.source. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Eagerly escape RegExp.source. Escaping used to happen lazily, implemented in an accessor property. However, native implementation of RegExp methods use .source as well. This leads to performance regressions. Now we do it eagerly instead. R=jkummerow@chromium.org BUG=chromium:436447 LOG=N Committed: https://crrev.com/4a5de9d9e36ff0f8e82ad7f7d48b37d608713b16 Cr-Commit-Position: refs/heads/master@{#27705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -103 lines) Patch
M src/accessors.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 4 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 8 months ago (2015-04-09 11:56:09 UTC) #1
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-09 12:55:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070093002/1
5 years, 8 months ago (2015-04-09 12:55:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 13:22:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 13:22:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a5de9d9e36ff0f8e82ad7f7d48b37d608713b16
Cr-Commit-Position: refs/heads/master@{#27705}

Powered by Google App Engine
This is Rietveld 408576698