Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3302)

Unified Diff: extensions/browser/extension_pref_value_map.cc

Issue 1070063002: Add debug data for incorrect access to preferences by extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_pref_value_map.cc
diff --git a/extensions/browser/extension_pref_value_map.cc b/extensions/browser/extension_pref_value_map.cc
index d21a96972fc05303bcd58a95ccd2fa0630a81fab..dd549d77c0d11dd98925a994474e6fb090fa9594 100644
--- a/extensions/browser/extension_pref_value_map.cc
+++ b/extensions/browser/extension_pref_value_map.cc
@@ -71,7 +71,10 @@ bool ExtensionPrefValueMap::CanExtensionControlPref(
bool incognito) const {
ExtensionEntryMap::const_iterator ext = entries_.find(extension_id);
if (ext == entries_.end()) {
- NOTREACHED();
+ NOTREACHED() << "Extension " << extension_id
+ << " is not registered but accesses pref " << pref_key
+ << " (incognito: " << incognito << ")."
+ << " http://crbug.com/454513";
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698