Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1070063002: Add debug data for incorrect access to preferences by extension. (Closed)

Created:
5 years, 8 months ago by battre
Modified:
5 years, 8 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Albert Bodenhamer, Peter Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add debug data for incorrect access to preferences by extension. BUG=454513, 467239 Committed: https://crrev.com/c17c9742f2968e7188f6211118d751ff8c99d8a6 Cr-Commit-Position: refs/heads/master@{#324601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M extensions/browser/extension_pref_value_map.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
battre
Hi Finnur, could you please review this? Thanks, Dominic
5 years, 8 months ago (2015-04-09 11:28:54 UTC) #2
Finnur
LGTM. Out of curiosity, is this a temporary measure until you find it or do ...
5 years, 8 months ago (2015-04-09 11:37:28 UTC) #3
battre
On 2015/04/09 11:37:28, Finnur wrote: > LGTM. > > Out of curiosity, is this a ...
5 years, 8 months ago (2015-04-10 07:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070063002/1
5 years, 8 months ago (2015-04-10 07:24:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 08:24:37 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 08:25:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c17c9742f2968e7188f6211118d751ff8c99d8a6
Cr-Commit-Position: refs/heads/master@{#324601}

Powered by Google App Engine
This is Rietveld 408576698