Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1070053004: Telemetry: Add WPR data for large profiles. (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 8 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Add WPR data for large profiles. This CL adds a new page set ProfileSafeUrlsPageSet, which is used by the CookieProfileExtender. This CL also hooks up WPR to the CookieProfileExtender. BUG=472745 Committed: https://crrev.com/553b419e9a4a9dc1eb0ac5845c04c1c99ba59e40 Cr-Commit-Position: refs/heads/master@{#325324}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Update profile safe url list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2648 lines, -2203 lines) Patch
A tools/perf/page_sets/data/profile_safe_urls.json View 1 2 3 1 chunk +507 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/profile_safe_urls_000.wpr.sha1 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/profile_safe_urls.py View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M tools/perf/profile_creators/cookie_profile_extender.py View 1 2 3 chunks +17 lines, -5 lines 0 comments Download
M tools/perf/profile_creators/profile_safe_url_generator.py View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M tools/perf/profile_creators/profile_safe_url_list.json View 1 2 3 61 chunks +2076 lines, -2192 lines 0 comments Download
M tools/perf/profile_creators/profile_safe_url_list.py View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
erikchen
dtu: Please review.
5 years, 8 months ago (2015-04-11 00:48:42 UTC) #2
dtu
lgtm
5 years, 8 months ago (2015-04-13 20:18:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070053004/40001
5 years, 8 months ago (2015-04-13 20:27:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/54971)
5 years, 8 months ago (2015-04-13 23:47:01 UTC) #7
erikchen
On 2015/04/13 23:47:01, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-15 20:07:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070053004/80001
5 years, 8 months ago (2015-04-15 20:09:06 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 8 months ago (2015-04-15 22:19:15 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 22:21:09 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/553b419e9a4a9dc1eb0ac5845c04c1c99ba59e40
Cr-Commit-Position: refs/heads/master@{#325324}

Powered by Google App Engine
This is Rietveld 408576698