Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 1070023002: Propagate bailout messages from the CPS IR backends. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add another giveup method. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/task.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart
index d631f286655f710e1b4320367c062ff39a75fd0f..2bd1b14382fe5aeb0948e29f03fe71849f0df732 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart
@@ -108,7 +108,11 @@ class CpsFunctionCompiler implements FunctionCompiler {
cps.FunctionDefinition cpsNode = irBuilderTask.buildNode(element);
if (cpsNode == null) {
- giveUp('unable to build cps definition of $element');
+ if (irBuilderTask.bailoutMessage == null) {
+ giveUp('unable to build cps definition of $element');
+ } else {
+ giveUp(irBuilderTask.bailoutMessage);
+ }
}
if (element.isInstanceMember && !element.isGenerativeConstructorBody) {
Selector selector = new Selector.fromElement(cpsNode.element);
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698