Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1070003002: [turbofan] Add poor man's store elimination for storing to fields. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add poor man's store elimination for storing to fields. This is a very simple dead store elimination that removes StoreField nodes which are immediately followed by other StoreField nodes that store to the same field. Ideally there should be a fully featured store elimination, which walks over the effect graph starting from the end, but there are some technical difficulties to solve before we can get to that, esp. we need to think about "effect producing" operators like ValueEffect first. Once we have that, it is trivial to remove this temporary poor man's store elimination. R=dcarney@chromium.org Committed: https://crrev.com/f190a6d23d6bc7cd17c54ad06e8e5924751e7e72 Cr-Commit-Position: refs/heads/master@{#27697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/compiler/simplified-operator-reducer.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-09 09:57:38 UTC) #1
Benedikt Meurer
PTAL
5 years, 8 months ago (2015-04-09 09:57:58 UTC) #2
dcarney
lgtm
5 years, 8 months ago (2015-04-09 09:58:54 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as f190a6d23d6bc7cd17c54ad06e8e5924751e7e72 (presubmit successful).
5 years, 8 months ago (2015-04-09 10:29:38 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 10:29:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f190a6d23d6bc7cd17c54ad06e8e5924751e7e72
Cr-Commit-Position: refs/heads/master@{#27697}

Powered by Google App Engine
This is Rietveld 408576698