Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 1069983005: Model 'await for' as an explicit node in tree and fix its handling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix failing assertion rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/registry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 652387b9ab146828326a32ce5cdb473311b9a15c..da697606a998ac59767d664a0b83b5d7da1d0866 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -3598,8 +3598,21 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
registry.registerDynamicInvocation(selector);
}
- visitForIn(ForIn node) {
- LibraryElement library = enclosingElement.library;
+ visitAsyncForIn(AsyncForIn node) {
+ registry.registerAsyncForIn(node);
+ registry.setCurrentSelector(node, compiler.currentSelector);
+ registry.registerDynamicGetter(compiler.currentSelector);
+ registry.setMoveNextSelector(node, compiler.moveNextSelector);
+ registry.registerDynamicInvocation(compiler.moveNextSelector);
+
+ visit(node.expression);
+
+ Scope blockScope = new BlockScope(scope);
+ visitForInDeclaredIdentifierIn(node.declaredIdentifier, node, blockScope);
+ visitLoopBodyIn(node, node.body, blockScope);
+ }
+
+ visitSyncForIn(SyncForIn node) {
registry.setIteratorSelector(node, compiler.iteratorSelector);
registry.registerDynamicGetter(compiler.iteratorSelector);
registry.setCurrentSelector(node, compiler.currentSelector);
@@ -3608,8 +3621,15 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
registry.registerDynamicInvocation(compiler.moveNextSelector);
visit(node.expression);
+
Scope blockScope = new BlockScope(scope);
- Node declaration = node.declaredIdentifier;
+ visitForInDeclaredIdentifierIn(node.declaredIdentifier, node, blockScope);
+ visitLoopBodyIn(node, node.body, blockScope);
+ }
+
+ visitForInDeclaredIdentifierIn(Node declaration, ForIn node,
+ Scope blockScope) {
+ LibraryElement library = enclosingElement.library;
bool oldAllowFinalWithoutInitializer = allowFinalWithoutInitializer;
allowFinalWithoutInitializer = true;
@@ -3659,7 +3679,6 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
// loopVariable may be null if it could not be resolved.
registry.setForInVariable(node, loopVariable);
}
- visitLoopBodyIn(node, node.body, blockScope);
}
visitLabel(Label node) {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/registry.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698