Implement Custom Element's class side inheritance

Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 168 matching lines @@
         v8Type = v8::Null(isolate);
 
     m_constructor->SetName(v8Type->IsNull() ? v8TagName : v8Type.As<v8::String>());
 
     V8HiddenValue::setHiddenValue(isolate, m_constructor, V8HiddenValue::customElementDocument(isolate), toV8(document, context->Global(), isolate));
     V8HiddenValue::setHiddenValue(isolate, m_constructor, V8HiddenValue::customElementNamespaceURI(isolate), v8String(isolate, descriptor.namespaceURI()));
     V8HiddenValue::setHiddenValue(isolate, m_constructor, V8HiddenValue::customElementTagName(isolate), v8TagName);
     V8HiddenValue::setHiddenValue(isolate, m_constructor, V8HiddenValue::customElementType(isolate), v8Type);
 
     v8::Local<v8::String> prototypeKey = v8String(isolate, "prototype");
+    v8::Local<v8::String> constructorKey = v8String(isolate, "constructor");

[dominicc (has gone to gerrit), 2015/04/09 06:37:57]

Move this down near to where it is used.

[deepak.s, 2015/04/15 06:44:53]

Done.

+
     if (!v8CallBoolean(m_constructor->HasOwnProperty(context, prototypeKey)))
         return false;
     // This sets the property *value*; calling Set is safe because
     // "prototype" is a non-configurable data property so there can be
     // no side effects.
     if (!v8CallBoolean(m_constructor->Set(context, prototypeKey, m_prototype)))
         return false;
     // This *configures* the property. ForceSet of a function's
     // "prototype" does not affect the value, but can reconfigure the
     // property.
     if (!v8CallBoolean(m_constructor->ForceSet(context, prototypeKey, m_prototype, v8::PropertyAttribute(v8::ReadOnly | v8::DontEnum | v8::DontDelete))))
         return false;
+    // The generated constructor should inherit from constructor.
+    if (!v8CallBoolean(m_constructor->SetPrototype(context, m_prototype->Get(constructorKey))))

[dominicc (has gone to gerrit), 2015/04/09 06:37:57]

FYI It looks like the bool SetPrototype is deprecated, but this is fine this way
because it's consistent with the surrounding stuff. We can update it later in a
clean-up pass.

https://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8.h&q=...

+        return false;
 
     V8HiddenValue::setHiddenValue(isolate, m_prototype, V8HiddenValue::customElementIsInterfacePrototypeObject(isolate), v8::True(isolate));
-    if (!v8CallBoolean(m_prototype->ForceSet(context, v8String(isolate, "constructor"), m_constructor, v8::DontEnum)))
+    if (!v8CallBoolean(m_prototype->ForceSet(context, constructorKey, m_constructor, v8::DontEnum)))
         return false;
 
     return true;
 }
 
 bool CustomElementConstructorBuilder::prototypeIsValid(const AtomicString& type, ExceptionState& exceptionState) const
 {
     if (m_prototype->InternalFieldCount() || !V8HiddenValue::getHiddenValue(m_scriptState->isolate(), m_prototype, V8HiddenValue::customElementIsInterfacePrototypeObject(m_scriptState->isolate())).IsEmpty()) {
         CustomElementException::throwException(CustomElementException::PrototypeInUse, type, exceptionState);
         return false;
@@ skipping 58 matching lines @@
 
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomElement", info.Holder(), info.GetIsolate());
     CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;
     RefPtrWillBeRawPtr<Element> element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, exceptionState);
     if (exceptionState.throwIfNeeded())
         return;
     v8SetReturnValueFast(info, element.release(), document);
 }
 
 } // namespace blink