LayoutTests/fast/dom/custom/registration-context-delete-during-register-base-constructor-retrieval-expected.txt - Issue 1069953002: Implement Custom Element's class side inheritance

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/custom/registration-context-delete-during-register-base-constructor-retrieval-expected.txt

Issue 1069953002: Implement Custom Element's class side inheritance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/dom/custom/inherited-prototype.html ('K') | « LayoutTests/fast/dom/custom/registration-context-delete-during-register-base-constructor-retrieval.html ('k') | Source/bindings/core/v8/CustomElementConstructorBuilder.cpp » ('j') | Source/bindings/core/v8/CustomElementConstructorBuilder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Tests destroying a context during registration at the point when the prototype i s retrieved.	1 Tests destroying a context during registration at the point when the prototype c onstructor prototype is retrieved.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6 PASS destroyed context	6 PASS caught expected exception "NotSupportedError: Failed to execute 'registerEl ement' on 'Document': Registration failed for type 'x-a'. Prototype constructor property is not configurable."
	dominicc (has gone to gerrit) 2015/04/09 06:37:57 It's a concern that "PASS destroyed context" isn't It's a concern that "PASS destroyed context" isn't showing up in the test output, and I'm not sure the error message that is showing up means this test is running as we want it to. That second error message originates from prototypeIsValid. deepak.s 2015/04/09 09:50:00 This is happening because it is failing to configu Show quoted text On 2015/04/09 06:37:57, dominicc wrote: > It's a concern that "PASS destroyed context" isn't showing up in the test > output, This is happening because it is failing to configure Prototype constructor property, which is valid as per this test also: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... That is why "PASS destroyed context" is not showing up. Show quoted text > and I'm not sure the error message that is showing up means this test is > running as we want it to. That second error message originates from > prototypeIsValid. Yeah, test is not running as per our expectations. Either we have to write 'configurable : true' in the constructor property, we have to test it some other way.
7 PASS caught expected exception "InvalidStateError: Failed to execute 'registerEl ement' on 'Document': Registration failed for type 'x-a'. The context is no long er valid."

8 PASS child done	7 PASS child done

9 PASS successfullyParsed is true	8 PASS successfullyParsed is true

10	9

11 TEST COMPLETE	10 TEST COMPLETE

12

OLD	NEW