Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1069943003: Revert of ChannelMojo: Ensure that it always has ScopedIPCSupport (Closed)

Created:
5 years, 8 months ago by Sorin Jianu
Modified:
5 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChannelMojo: Ensure that it always has ScopedIPCSupport (patchset #1 id:1 of https://codereview.chromium.org/1054253005/) Reason for revert: It breaks the lkgr bots for various win ASAN, such as: http://build.chromium.org/p/chromium.lkgr/waterfall?builder=Win%20ASan%20Release [17485/19602] CXX obj\content\test\test_support_content.fake_plugin_service.obj FAILED: ninja -t msvc -e environment.x86 -- "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo /showIncludes /FC @obj\tools\ipc_fuzzer\message_replay\ipc_fuzzer_replay.replay_process.obj.rsp /c ..\..\tools\ipc_fuzzer\message_replay\replay_process.cc /Foobj\tools\ipc_fuzzer\message_replay\ipc_fuzzer_replay.replay_process.obj /Fdobj\tools\ipc_fuzzer\message_replay\ipc_fuzzer_replay.cc.pdb ..\..\tools\ipc_fuzzer\message_replay\replay_process.cc(96,68) : error(clang): too few arguments to function call, expected 3, have 2 IPC::ChannelMojo::CreateClientFactory(nullptr, channel_name), this, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ..\..\ipc/mojo/ipc_channel_mojo.h(80,3) : note(clang): 'CreateClientFactory' declared here static scoped_ptr<ChannelFactory> CreateClientFactory( ^ 1 error generated. clang-cl.exe: warning: falling back to C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\bin\amd64_x86\cl.exe clang-cl.exe: error: clang frontend command failed with exit code 2 (use -v to see invocation) ..\..\tools\ipc_fuzzer\message_replay\replay_process.cc(96) : error C2660: 'IPC::ChannelMojo::CreateClientFactory' : function does not take 2 arguments Original issue's description: > ChannelMojo: Ensure that it always has ScopedIPCSupport > > ChannelMojo has ScopedIPCSupport, but it is instantiated only in > in-process mode. This CL lets it always instantiate to make it > clear that ChannelInfo is protected by the ScopedIPCSupport. > It simplifies the relationship between the support object and > the channel, and makes the lifecycle invariant reasonable. > > With this change, we no longer need to protect ChannelMojo with > ScopedIPCSupport on its client side. Now it's built-in. > > Note that this is a speculative fix of fuzzer generated crash, > where Mojo channel related globals are gone before when channel > mojo is being destroyed. > > BUG=473438 > R=viettrungluu@chromium.org, rockot@chromium.org > > Committed: https://crrev.com/808706e71c213c916815e967e3156cae64d12c00 > Cr-Commit-Position: refs/heads/master@{#324308} TBR=rockot@chromium.org,viettrungluu@chromium.org,creis@chromium.org,morrita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473438 Committed: https://crrev.com/87a51a7345593c850ed196791c66cc6ab30479a0 Cr-Commit-Position: refs/heads/master@{#324457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -65 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +49 lines, -3 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 4 chunks +6 lines, -10 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 9 chunks +25 lines, -38 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_host.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 6 chunks +14 lines, -5 lines 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sorin Jianu
Created Revert of ChannelMojo: Ensure that it always has ScopedIPCSupport
5 years, 8 months ago (2015-04-09 16:23:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069943003/1
5 years, 8 months ago (2015-04-09 16:23:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 16:24:49 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 16:25:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87a51a7345593c850ed196791c66cc6ab30479a0
Cr-Commit-Position: refs/heads/master@{#324457}

Powered by Google App Engine
This is Rietveld 408576698