Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1069853004: Windows compile fixes for Chrome clang plugin. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Windows compile fixes for Chrome clang plugin. Symlinks aren't very common on Windows anyway. BUG=467287 Committed: https://crrev.com/e9f7a955f3365c7ed88b25327ccfedd6b1778ee0 Cr-Commit-Position: refs/heads/master@{#324364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/clang/plugins/ChromeClassTester.cpp View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
The first step of many. I'm manually confirming that LLVM_ON_UNIX is defined on Mac, but ...
5 years, 8 months ago (2015-04-08 23:19:18 UTC) #2
hans
On 2015/04/08 23:19:18, dcheng wrote: > The first step of many. I'm manually confirming that ...
5 years, 8 months ago (2015-04-08 23:42:17 UTC) #3
dcheng
On 2015/04/08 at 23:42:17, hans wrote: > On 2015/04/08 23:19:18, dcheng wrote: > > The ...
5 years, 8 months ago (2015-04-09 00:02:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069853004/1
5 years, 8 months ago (2015-04-09 00:03:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 04:12:15 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 04:13:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9f7a955f3365c7ed88b25327ccfedd6b1778ee0
Cr-Commit-Position: refs/heads/master@{#324364}

Powered by Google App Engine
This is Rietveld 408576698