Implement Element.matches(selectors)

Implement Element.matches(selectors)

http://dom.spec.whatwg.org/#dom-element-matches

No tested browser (Firefox Nightly, IE11 Release Preview, Opera 12.16)
has implemented the unprefixed API yet.

Having verified that the other browsers throw an exception for
*MatchesSelector(), make the argument to webkitMatchesSelector()
non-optional to align with them and the unprefixed API.

The spec requires throwing a TypeError when parsing the selectors
fails, but we currently throw a SyntaxError. So do the other browsers
for *MatchesSelector(), so file a spec bug instead of changing it:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=24028

BUG=326652
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163442

[philipj_slow, 2013-12-06 22:56:52]

Does this need an intent to implement and ship? I invoke the trivial clause!

[eseidel, 2013-12-07 00:41:22]

Please provide a nicer description (as that becomes part of the permanent commit
log record).

What spec is this from? What other browsers implement it?  Why is it trivial,
etc.

[philipj_slow, 2013-12-07 10:05:31]

On 2013/12/07 00:41:22, eseidel wrote:
> Please provide a nicer description (as that becomes part of the permanent
commit
> log record).
> 
> What spec is this from? What other browsers implement it?  Why is it trivial,
> etc.

I've updated the description, but will also send an intent to implement since
Paul Irish asked for it in the bug.

[philipj_slow, 2013-12-08 08:11:25]

PTAL, blink-dev thread and trybots both look good.

[arv (Not doing code reviews), 2013-12-09 14:52:30]

LGTM

[jochen (gone - plz use gerrit), 2013-12-09 14:53:35]

lgtm

[commit-bot: I haz the power, 2013-12-09 15:13:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/106983004/40001

[commit-bot: I haz the power, 2013-12-09 16:51:24]

Change committed as 163442

[adamk, 2013-12-09 21:23:01]

On 2013/12/09 16:51:24, I haz the power (commit-bot) wrote:
> Change committed as 163442

This change is causing failures on the linux_chromeos browser_tests:

http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...

Those failures are blocking the Blink roll. I'd like to revert this patch for
now to unblock the roll.

[philipj_slow, 2013-12-09 21:39:16]

On 2013/12/09 21:23:01, adamk wrote:
> On 2013/12/09 16:51:24, I haz the power (commit-bot) wrote:
> > Change committed as 163442
> 
> This change is causing failures on the linux_chromeos browser_tests:
> 
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...
> 
> Those failures are blocking the Blink roll. I'd like to revert this patch for
> now to unblock the roll.

Please go ahead, will investigate what went wrong and try again.

[adamk, 2013-12-09 21:47:26]

On 2013/12/09 21:39:16, philipj wrote:
> On 2013/12/09 21:23:01, adamk wrote:
> > On 2013/12/09 16:51:24, I haz the power (commit-bot) wrote:
> > > Change committed as 163442
> > 
> > This change is causing failures on the linux_chromeos browser_tests:
> > 
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...
> > 
> > Those failures are blocking the Blink roll. I'd like to revert this patch
for
> > now to unblock the roll.
> 
> Please go ahead, will investigate what went wrong and try again.

Thanks, already reverted as
https://src.chromium.org/viewvc/blink?view=rev&revision=163457

To reproduce this on Linux, you simply need to have "chromeos=1" in your
GYP_DEFINES, and run browser_tests with --gtest_filter=VirtualKeyboad*