Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1069753002: Update the Settings Override API documentation. (Closed)

Created:
5 years, 8 months ago by vasilii
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the Settings Override API documentation. It should mention that Windows is the only supported platform. BUG=474961 Committed: https://crrev.com/b13664617e29d43ec3e848c3680f26ee12e922ed Cr-Commit-Position: refs/heads/master@{#324398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/common/extensions/docs/templates/articles/settings_override.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vasilii
Hi Ben, please review.
5 years, 8 months ago (2015-04-08 14:28:22 UTC) #2
not at google - send to devlin
lgtm
5 years, 8 months ago (2015-04-08 17:01:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069753002/1
5 years, 8 months ago (2015-04-09 08:30:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 08:37:09 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 08:37:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b13664617e29d43ec3e848c3680f26ee12e922ed
Cr-Commit-Position: refs/heads/master@{#324398}

Powered by Google App Engine
This is Rietveld 408576698