Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 106973009: DevTools: Display function names instead of general "[Async Call]". (Closed)

Created:
7 years ago by aandrey
Modified:
7 years ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Display function names instead of general "[Async Call]". Display async call function's name, like setTimeout or requestAnimationFrame. BUG=272416 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163561

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : +test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -51 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M LayoutTests/inspector/debugger/async-callstack-expected.txt View 1 2 1 chunk +34 lines, -34 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 4 chunks +12 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/CallStackSidebarPane.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/DebuggerModel.js View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aandrey
7 years ago (2013-12-10 15:06:13 UTC) #1
pfeldman
lgtm
7 years ago (2013-12-10 15:07:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/106973009/30001
7 years ago (2013-12-10 19:01:36 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-10 20:13:06 UTC) #4
Message was sent while issue was closed.
Change committed as 163561

Powered by Google App Engine
This is Rietveld 408576698