Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 106973005: Improve load elimination handling of transitioning stores. (Closed)

Created:
7 years ago by titzer
Modified:
7 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Improve load elimination handling of transitioning stores. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18388

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added new cases to existing load elimination tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M src/hydrogen-load-elimination.cc View 7 chunks +6 lines, -10 lines 0 comments Download
M test/mjsunit/compiler/load-elimination.js View 1 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
https://codereview.chromium.org/106973005/diff/1/src/hydrogen-load-elimination.cc File src/hydrogen-load-elimination.cc (left): https://codereview.chromium.org/106973005/diff/1/src/hydrogen-load-elimination.cc#oldcode46 src/hydrogen-load-elimination.cc:46: HLoadNamedField* last_load_; Note that this field was really only ...
7 years ago (2013-12-06 08:40:04 UTC) #1
Toon Verwaest
LGTM. We should also use transitioning information to distinguish receivers. The receiver cannot alias any ...
7 years ago (2013-12-06 10:14:50 UTC) #2
titzer
On 2013/12/06 10:14:50, Toon Verwaest wrote: > LGTM. I've added a test case and verified ...
7 years ago (2013-12-20 09:05:11 UTC) #3
titzer
7 years ago (2013-12-20 12:12:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18388 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698