Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1069673002: Add more systematic tests for comparisons. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add more systematic tests for comparisons. Because, well, JavaScript is tricky and compilers like folding. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/1b400a14cb0e3d57e87a190520f6b103858e33d1 Cr-Commit-Position: refs/heads/master@{#27668}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+948 lines, -0 lines) Patch
A test/mjsunit/compare-table-eq.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/compare-table-gt.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/compare-table-gteq.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/compare-table-lt.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/compare-table-lteq.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/compare-table-ne.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/compare-table-seq.js View 1 chunk +105 lines, -0 lines 0 comments Download
A test/mjsunit/compare-table-sne.js View 1 chunk +105 lines, -0 lines 0 comments Download
A tools/compare-table-gen.js View 1 1 chunk +108 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 8 months ago (2015-04-08 09:16:58 UTC) #1
Michael Starzinger
LGTM (rubber-stamped). But could we also check-in the generator script somewhere somehow?
5 years, 8 months ago (2015-04-08 12:09:27 UTC) #2
titzer
On 2015/04/08 12:09:27, Michael Starzinger wrote: > LGTM (rubber-stamped). But could we also check-in the ...
5 years, 8 months ago (2015-04-08 12:50:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069673002/20001
5 years, 8 months ago (2015-04-08 12:50:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 13:15:38 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 13:15:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b400a14cb0e3d57e87a190520f6b103858e33d1
Cr-Commit-Position: refs/heads/master@{#27668}

Powered by Google App Engine
This is Rietveld 408576698