native_client_sdk/src/examples/api/video_encode/video_encode.cc - Issue 1069653002: ppapi: VideoEncoder: fix reported value for GetSupportedProfiles()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/examples/api/video_encode/video_encode.cc

Issue 1069653002: ppapi: VideoEncoder: fix reported value for GetSupportedProfiles() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bbudge's nit Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/examples/api/video_encode/video_encode.cc

diff --git a/native_client_sdk/src/examples/api/video_encode/video_encode.cc b/native_client_sdk/src/examples/api/video_encode/video_encode.cc

index 702786c0ed8a16a395a60cd79dda412357d4b4a6..806bca498d3d0f0ebced3cf5c2c87fdd7371cf49 100644

--- a/native_client_sdk/src/examples/api/video_encode/video_encode.cc

+++ b/native_client_sdk/src/examples/api/video_encode/video_encode.cc

@@ -281,7 +281,7 @@ void VideoEncoderInstance::OnEncoderProbed(

pp::VarArray js_profiles;

dict.Set(pp::Var("profiles"), js_profiles);

- if (result != PP_OK) {

+ if (result < 0) {

LogError(result, "Cannot get supported profiles");

PostMessage(dict);

}

« no previous file with comments | « no previous file | ppapi/examples/video_encode/video_encode.cc » ('j') | no next file with comments »