Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1069653002:
ppapi: VideoEncoder: fix reported value for GetSupportedProfiles() (Closed)
|
Created:
5 years, 8 months ago by llandwerlin-old Modified:
5 years, 8 months ago CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionppapi: VideoEncoder: fix reported value for GetSupportedProfiles()
GetSupportedProfiles() should return the number of supported profiles
or a negative value in case of error. Prior to this change, we
reported PP_OK instead of the number of profiles.
BUG=455409
Committed: https://crrev.com/efb23ba854a52a7363e287ba5501b7d933b235ff
Cr-Commit-Position: refs/heads/master@{#325649}
Patch Set 1 #
Total comments: 1
Patch Set 2 : bbudge's nit #
Messages
Total messages: 42 (19 generated)
lionel.g.landwerlin@intel.com changed reviewers: + bbudge@chromium.org, binji@chromium.org
bbudge@, binji@: PTAL, Thanks.
LGTM w/1 nit https://codereview.chromium.org/1069653002/diff/1/ppapi/proxy/video_encoder_r... File ppapi/proxy/video_encoder_resource.cc (right): https://codereview.chromium.org/1069653002/diff/1/ppapi/proxy/video_encoder_r... ppapi/proxy/video_encoder_resource.cc:271: static_cast<int32_t>(profiles.size())); nit: base::checked_cast is how we're doing this now.
binji@: ping?
sorry, I didn't see this CL. native_client_sdk lgtm
The CQ bit was checked by lionel.g.landwerlin@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org Link to the patchset: https://codereview.chromium.org/1069653002/#ps20001 (title: "bbudge's nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
On 2015/04/17 00:11:32, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) I've been told someone is working on the spurious trybot failure. Hopefully we can CQ this tomorrow.
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
The CQ bit was unchecked by lionel.g.landwerlin@intel.com
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069653002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/efb23ba854a52a7363e287ba5501b7d933b235ff Cr-Commit-Position: refs/heads/master@{#325649} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
