Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1069633002: [arm] Use position independent table switches. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Use position independent table switches. Performance measurements show that the position independent code is usually slightly faster than the position dependent code, and there seems to be no noticable regression. This also gets rid of a lot of support code that was only required to allow embedding labels into the code stream. And it implies that neither the GC nor the deserializer need to do anything for jump tables. R=svenpanne@chromium.org BUG=v8:3872 LOG=n Committed: https://crrev.com/aa46ebe5e297af02a59ce67e13ce0fb9ebab26cb Cr-Commit-Position: refs/heads/master@{#27646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -244 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 5 chunks +23 lines, -73 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-08 05:33:16 UTC) #1
Benedikt Meurer
Hey Sven, This improves the performance of switches on ARM, and also gets rid of ...
5 years, 8 months ago (2015-04-08 05:34:34 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-08 06:48:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069633002/1
5 years, 8 months ago (2015-04-08 06:48:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 06:50:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 06:50:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa46ebe5e297af02a59ce67e13ce0fb9ebab26cb
Cr-Commit-Position: refs/heads/master@{#27646}

Powered by Google App Engine
This is Rietveld 408576698