content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager.cc ('K') | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/renderer_host/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index 2ba5fb8493ac5b7e58cdca68f655ae18a118858e..1a2b83f1e74b064468ed8e5ddae89b4ec1094a45 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -1058,20 +1058,20 @@ TEST_F(RenderFrameHostManagerTest, CreateSwappedOutOpenerRVHs) {

rvh2->GetSiteInstance()));

// Ensure rvh1 is placed on swapped out list of the current tab.

- EXPECT_TRUE(manager->IsOnSwappedOutList(rvh1));

+ EXPECT_TRUE(manager->IsRVHOnSwappedOutList(rvh1));

EXPECT_EQ(rvh1,

manager->GetSwappedOutRenderViewHost(rvh1->GetSiteInstance()));

// Ensure a swapped out RVH is created in the first opener tab.

TestRenderViewHost* opener1_rvh = static_cast<TestRenderViewHost*>(

opener1_manager->GetSwappedOutRenderViewHost(rvh2->GetSiteInstance()));

- EXPECT_TRUE(opener1_manager->IsOnSwappedOutList(opener1_rvh));

+ EXPECT_TRUE(opener1_manager->IsRVHOnSwappedOutList(opener1_rvh));

EXPECT_TRUE(opener1_rvh->is_swapped_out());

// Ensure a swapped out RVH is created in the second opener tab.

TestRenderViewHost* opener2_rvh = static_cast<TestRenderViewHost*>(

opener2_manager->GetSwappedOutRenderViewHost(rvh2->GetSiteInstance()));

- EXPECT_TRUE(opener2_manager->IsOnSwappedOutList(opener2_rvh));

+ EXPECT_TRUE(opener2_manager->IsRVHOnSwappedOutList(opener2_rvh));

EXPECT_TRUE(opener2_rvh->is_swapped_out());

// Navigate to a cross-BrowsingInstance URL.

@@ -1173,7 +1173,7 @@ TEST_F(RenderFrameHostManagerTest, EnableWebUIWithSwappedOutOpener) {