content/test/test_render_view_host_factory.h - Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_view_host_factory.h

Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Nasko's comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager.cc ('K') | « content/test/test_render_view_host.cc ('k') | content/test/test_render_view_host_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/test_render_view_host_factory.h

diff --git a/content/test/test_render_view_host_factory.h b/content/test/test_render_view_host_factory.h

index df6a2d08ed50300f6f92a16d3e99e00c1b83e54c..e93762f25a85e95d88574bfa7c9d32bd10af7985 100644

--- a/content/test/test_render_view_host_factory.h

+++ b/content/test/test_render_view_host_factory.h

@@ -30,7 +30,6 @@ class TestRenderViewHostFactory : public RenderViewHostFactory {

virtual RenderViewHost* CreateRenderViewHost(

SiteInstance* instance,

RenderViewHostDelegate* delegate,

- RenderFrameHostDelegate* frame_delegate,

RenderWidgetHostDelegate* widget_delegate,

int routing_id,

int main_frame_routing_id,