content/test/test_render_frame_host.cc - Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Nasko's comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager.cc ('K') | « content/renderer/resource_fetcher_browsertest.cc ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index 57f8c0fe5122ac564bb1d3b413380759177eaa69..e9a3bc8d3e30be01812a0f78357fe520491675ea 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -4,6 +4,9 @@

#include "content/test/test_render_frame_host.h"

+#include "content/browser/frame_host/frame_tree.h"

+#include "content/test/test_render_view_host.h"

namespace content {

TestRenderFrameHost::TestRenderFrameHost(RenderViewHostImpl* render_view_host,

@@ -17,7 +20,13 @@ TestRenderFrameHost::TestRenderFrameHost(RenderViewHostImpl* render_view_host,

frame_tree,

frame_tree_node,

routing_id,

- is_swapped_out) {}

+ is_swapped_out) {

+ // Allow TestRenderViewHosts to easily access their main frame RFH.

+ if (frame_tree_node == frame_tree->root()) {

+ static_cast<TestRenderViewHost*>(render_view_host)->

+ set_main_render_frame_host(this);

+ }

TestRenderFrameHost::~TestRenderFrameHost() {}