content/browser/frame_host/render_frame_host_impl.h - Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 106963004: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Nasko's comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 2822724adfae45a5a56fc078e29376f9ccae6e47..f00604a013705b0c77c7dad8ce249d3321fb5313 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -76,8 +76,13 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost {

bool is_swapped_out() { return is_swapped_out_; }

- // TODO(nasko): This should be removed and replaced by RenderProcessHost.

- RenderViewHostImpl* render_view_host_; // Not owned.

+ // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a

+ // refcount that calls Shutdown when it reaches zero. This allows each

+ // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring

+ // we have a RenderViewHost for each RenderFrameHost.

+ // TODO(creis): RenderViewHost will eventually go away and be replaced with

+ // some form of page context.

+ RenderViewHostImpl* render_view_host_;

RenderFrameHostDelegate* delegate_;