Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/BUILD.gn

Issue 1069533002: GN Windows component build fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 229863c119c064ca6d72e5370924794ba64580f4..feb8ae5a4596c5e906d50428078d6214f8325945 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -22,6 +22,7 @@ if (!is_android) {
sources = [
"app/chrome_exe_resource.h",
]
+ defines = []
deps = []
datadeps = []
@@ -51,6 +52,13 @@ if (!is_android) {
"common/crash_keys.cc",
"common/crash_keys.h'",
]
+
+ if (is_component_build) {
+ # This is necessary to make content_switches compile without DLL
+ # linkage errors in a component build.
+ defines += [ "COMPILE_CONTENT_STATICALLY" ]
+ }
+
deps += [
":chrome_version_resources",
":image_pre_reader",
@@ -206,7 +214,7 @@ shared_library("main_dll") {
#TODO(GYP) add chrome_multiple_dll support
if (false) { #chrome_multiple_dll) {
- defines = [ "CHROME_MULTIPLE_DLL_BROWSER" ]
+ defines += [ "CHROME_MULTIPLE_DLL_BROWSER" ]
deps += [ "//content/public/app:browser" ]
} else {
deps += [
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698