Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/BUILD.gn

Issue 1069533002: GN Windows component build fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/locales.gni") 6 import("//build/config/locales.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//chrome/chrome_repack_locales.gni") 8 import("//chrome/chrome_repack_locales.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 10
11 if (is_android) { 11 if (is_android) {
12 import("//build/config/android/rules.gni") 12 import("//build/config/android/rules.gni")
13 } 13 }
14 14
15 if (!is_android) { 15 if (!is_android) {
16 # TODO(GYP) for Windows need to the the reorder-imports step which probably 16 # TODO(GYP) for Windows need to the the reorder-imports step which probably
17 # means adding another target and renaming this to chrome_initial like in GYP. 17 # means adding another target and renaming this to chrome_initial like in GYP.
18 executable("chrome") { 18 executable("chrome") {
19 # Because the sources list varies so significantly per-platform, generally 19 # Because the sources list varies so significantly per-platform, generally
20 # each platform lists its own files rather than relying on filtering or 20 # each platform lists its own files rather than relying on filtering or
21 # removing unused files. 21 # removing unused files.
22 sources = [ 22 sources = [
23 "app/chrome_exe_resource.h", 23 "app/chrome_exe_resource.h",
24 ] 24 ]
25 defines = []
25 deps = [] 26 deps = []
26 datadeps = [] 27 datadeps = []
27 28
28 # TODO(GYP) mac_bundle_resources, xcode_settings 29 # TODO(GYP) mac_bundle_resources, xcode_settings
29 30
30 # TODO(GYP) order_profiling, order_text_section 31 # TODO(GYP) order_profiling, order_text_section
31 32
32 if (is_win) { 33 if (is_win) {
33 sources += [ 34 sources += [
34 "$target_gen_dir/chrome_exe_version.rc", 35 "$target_gen_dir/chrome_exe_version.rc",
35 "//content/app/startup_helper_win.cc", 36 "//content/app/startup_helper_win.cc",
36 "//content/public/common/content_switches.cc", 37 "//content/public/common/content_switches.cc",
37 "app/chrome_crash_reporter_client.cc", 38 "app/chrome_crash_reporter_client.cc",
38 "app/chrome_crash_reporter_client.h", 39 "app/chrome_crash_reporter_client.h",
39 "app/chrome_exe.rc", 40 "app/chrome_exe.rc",
40 "app/chrome_exe_main_win.cc", 41 "app/chrome_exe_main_win.cc",
41 "app/chrome_watcher_client_win.cc", 42 "app/chrome_watcher_client_win.cc",
42 "app/chrome_watcher_client_win.h", 43 "app/chrome_watcher_client_win.h",
43 "app/chrome_watcher_command_line_win.cc", 44 "app/chrome_watcher_command_line_win.cc",
44 "app/chrome_watcher_command_line_win.h", 45 "app/chrome_watcher_command_line_win.h",
45 "app/client_util.cc", 46 "app/client_util.cc",
46 "app/client_util.h", 47 "app/client_util.h",
47 "app/kasko_client.cc", 48 "app/kasko_client.cc",
48 "app/kasko_client.h", 49 "app/kasko_client.h",
49 "app/signature_validator_win.cc", 50 "app/signature_validator_win.cc",
50 "app/signature_validator_win.h", 51 "app/signature_validator_win.h",
51 "common/crash_keys.cc", 52 "common/crash_keys.cc",
52 "common/crash_keys.h'", 53 "common/crash_keys.h'",
53 ] 54 ]
55
56 if (is_component_build) {
57 # This is necessary to make content_switches compile without DLL
58 # linkage errors in a component build.
59 defines += [ "COMPILE_CONTENT_STATICALLY" ]
60 }
61
54 deps += [ 62 deps += [
55 ":chrome_version_resources", 63 ":chrome_version_resources",
56 ":image_pre_reader", 64 ":image_pre_reader",
57 ":main_dll", 65 ":main_dll",
58 66
59 # 'chrome_nacl_win64" TODO(GYP) 67 # 'chrome_nacl_win64" TODO(GYP)
60 # '../win8/delegate_execute/delegate_execute.gyp:*', TODO(GYP) 68 # '../win8/delegate_execute/delegate_execute.gyp:*', TODO(GYP)
61 # '../win8/metro_driver/metro_driver.gyp:metro_driver', TODO(GYP) 69 # '../win8/metro_driver/metro_driver.gyp:metro_driver', TODO(GYP)
62 "//base", 70 "//base",
63 "//breakpad:breakpad_handler", 71 "//breakpad:breakpad_handler",
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 207
200 # TODO(GYP) chrome_pgo_phase on Windows. 208 # TODO(GYP) chrome_pgo_phase on Windows.
201 } 209 }
202 210
203 if (use_aura) { 211 if (use_aura) {
204 deps += [ "//ui/compositor" ] 212 deps += [ "//ui/compositor" ]
205 } 213 }
206 214
207 #TODO(GYP) add chrome_multiple_dll support 215 #TODO(GYP) add chrome_multiple_dll support
208 if (false) { #chrome_multiple_dll) { 216 if (false) { #chrome_multiple_dll) {
209 defines = [ "CHROME_MULTIPLE_DLL_BROWSER" ] 217 defines += [ "CHROME_MULTIPLE_DLL_BROWSER" ]
210 deps += [ "//content/public/app:browser" ] 218 deps += [ "//content/public/app:browser" ]
211 } else { 219 } else {
212 deps += [ 220 deps += [
213 ":child_dependencies", 221 ":child_dependencies",
214 "//content/public/app:both", 222 "//content/public/app:both",
215 ] 223 ]
216 } 224 }
217 225
218 if (cld_version == 0 || cld_version == 2) { 226 if (cld_version == 0 || cld_version == 2) {
219 deps += [ "//third_party/cld_2" ] 227 deps += [ "//third_party/cld_2" ]
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 742
735 args = [ 743 args = [
736 rebase_path(infile, root_build_dir), 744 rebase_path(infile, root_build_dir),
737 rebase_path(outfile, root_build_dir), 745 rebase_path(outfile, root_build_dir),
738 "-e s/@@NAME@@/$name/", 746 "-e s/@@NAME@@/$name/",
739 "-e s/@@FILENAME@@/$filename/", 747 "-e s/@@FILENAME@@/$filename/",
740 "-e s/@@CONFDIR@@/$confdir/", 748 "-e s/@@CONFDIR@@/$confdir/",
741 ] 749 ]
742 } 750 }
743 } 751 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698