Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1069533002: GN Windows component build fixes. (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tim+watch_chromium.org, sadrul, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, jam, rickyz+watch_chromium.org, plaree+watch_chromium.org, darin-cc_chromium.org, albertb+watch_chromium.org, tfarina, kalyank, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN Windows component build fixes. Fixes issues related to compiling chrome in component mode on Windows. This just does chrome, there are likely other issues for test targets. Getting Chrome to work will also require an ANGLE roll. I converted two static_library -> source_set. These aren't necessary but I noticed the extra .libs were being created and these don't need real static libraries as far as I can tell. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/44a5cf89809a419225709657e86562137bb639b4 Cr-Commit-Position: refs/heads/master@{#324274}

Patch Set 1 #

Patch Set 2 : Linux fix #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M chrome/BUILD.gn View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/proto/BUILD.gn View 1 chunk +12 lines, -1 line 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sync/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sync/protocol/BUILD.gn View 1 chunk +11 lines, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
brettw
5 years, 8 months ago (2015-04-07 23:07:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069533002/1
5 years, 8 months ago (2015-04-07 23:08:28 UTC) #4
Dirk Pranke
lgtm, but you should probably re-format the CL description to be less wide.
5 years, 8 months ago (2015-04-07 23:11:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/314)
5 years, 8 months ago (2015-04-07 23:22:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069533002/20001
5 years, 8 months ago (2015-04-07 23:38:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/317)
5 years, 8 months ago (2015-04-07 23:52:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069533002/40001
5 years, 8 months ago (2015-04-08 17:22:52 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-08 19:48:36 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 19:49:27 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44a5cf89809a419225709657e86562137bb639b4
Cr-Commit-Position: refs/heads/master@{#324274}

Powered by Google App Engine
This is Rietveld 408576698