Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: cc/debug/rasterize_and_record_benchmark.cc

Issue 1069503002: [S.P.] Fix rasterize_and_record benchmark to include SkPicture playback time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/rasterize_and_record_benchmark.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/rasterize_and_record_benchmark.cc
diff --git a/cc/debug/rasterize_and_record_benchmark.cc b/cc/debug/rasterize_and_record_benchmark.cc
index 73a0fa5657b8772b3a7e64f94dcc13840c9b50dc..54f48f3b820aec107acffdb9a28b66f8f67bd233 100644
--- a/cc/debug/rasterize_and_record_benchmark.cc
+++ b/cc/debug/rasterize_and_record_benchmark.cc
@@ -105,21 +105,21 @@ scoped_ptr<MicroBenchmarkImpl> RasterizeAndRecordBenchmark::CreateBenchmarkImpl(
void RasterizeAndRecordBenchmark::RunOnLayer(PictureLayer* layer) {
DCHECK(host_);
- gfx::Rect visible_content_rect = gfx::ScaleToEnclosingRect(
+ gfx::Rect visible_layer_rect = gfx::ScaleToEnclosingRect(
layer->visible_content_rect(), 1.f / layer->contents_scale_x());
- if (visible_content_rect.IsEmpty())
+ if (visible_layer_rect.IsEmpty())
return;
if (host_->settings().use_display_lists) {
- RunOnDisplayListLayer(layer, visible_content_rect);
+ RunOnDisplayListLayer(layer, visible_layer_rect);
} else {
- RunOnPictureLayer(layer, visible_content_rect);
+ RunOnPictureLayer(layer, visible_layer_rect);
}
}
void RasterizeAndRecordBenchmark::RunOnPictureLayer(
PictureLayer* layer,
- const gfx::Rect& visible_content_rect) {
+ const gfx::Rect& visible_layer_rect) {
ContentLayerClient* painter = layer->client();
DCHECK(host_ && !host_->settings().use_display_lists);
@@ -141,7 +141,7 @@ void RasterizeAndRecordBenchmark::RunOnPictureLayer(
kTimeCheckInterval);
scoped_refptr<Picture> picture;
do {
- picture = Picture::Create(visible_content_rect, painter, tile_grid_size,
+ picture = Picture::Create(visible_layer_rect, painter, tile_grid_size,
false, mode);
if (memory_used) {
// Verify we are recording the same thing each time.
@@ -161,7 +161,7 @@ void RasterizeAndRecordBenchmark::RunOnPictureLayer(
if (mode == RecordingSource::RECORD_NORMALLY) {
record_results_.bytes_used += memory_used;
record_results_.pixels_recorded +=
- visible_content_rect.width() * visible_content_rect.height();
+ visible_layer_rect.width() * visible_layer_rect.height();
}
record_results_.total_best_time[mode_index] += min_time;
}
@@ -169,7 +169,7 @@ void RasterizeAndRecordBenchmark::RunOnPictureLayer(
void RasterizeAndRecordBenchmark::RunOnDisplayListLayer(
PictureLayer* layer,
- const gfx::Rect& visible_content_rect) {
+ const gfx::Rect& visible_layer_rect) {
ContentLayerClient* painter = layer->client();
DCHECK(host_ && host_->settings().use_display_lists);
@@ -207,8 +207,9 @@ void RasterizeAndRecordBenchmark::RunOnDisplayListLayer(
kTimeCheckInterval);
do {
- display_list = painter->PaintContentsToDisplayList(visible_content_rect,
+ display_list = painter->PaintContentsToDisplayList(visible_layer_rect,
painting_control);
+ display_list->CreateAndCacheSkPicture();
if (memory_used) {
// Verify we are recording the same thing each time.
@@ -228,7 +229,7 @@ void RasterizeAndRecordBenchmark::RunOnDisplayListLayer(
if (mode_index == RecordingSource::RECORD_NORMALLY) {
record_results_.bytes_used += memory_used;
record_results_.pixels_recorded +=
- visible_content_rect.width() * visible_content_rect.height();
+ visible_layer_rect.width() * visible_layer_rect.height();
}
record_results_.total_best_time[mode_index] += min_time;
}
« no previous file with comments | « cc/debug/rasterize_and_record_benchmark.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698