implement opassign, fix bugs in pre/postfix, introduce a let* helper

lib/runtime/dart/_js_helper.js

 var _js_helper;
 (function(exports) {
   'use strict';
   class NoSideEffects extends core.Object {
     NoSideEffects() {
     }
   }
   class NoThrows extends core.Object {
     NoThrows() {
     }
@@ skipping 542 matching lines @@
       return new _MatchImplementation(this, dart.as(match, core.List$(core.String)));
     }
     [_execAnchored](string, start) {
       let regexp = this[_nativeAnchoredVersion];
       regexp.lastIndex = start;
       let match = dart.as(regexp.exec(string), core.List);
       if (match == null)
         return null;
       if (match[core.$get](dart.notNull(match[core.$length]) - 1) != null)
         return null;
-      match[core.$length] = 1;
+      match[core.$length] = dart.notNull(match[core.$length]) - 1;
       return new _MatchImplementation(this, dart.as(match, core.List$(core.String)));
     }
     matchAsPrefix(string, start) {
       if (start === void 0)
         start = 0;
       if (dart.notNull(start) < 0 || dart.notNull(start) > dart.notNull(string.length)) {
         throw new core.RangeError.range(start, 0, string.length);
       }
       return this[_execAnchored](string, start);
     }
@@ skipping 237 matching lines @@
     let length = dart.as(dart.dload(receiver, 'length'), core.int);
     let i = 0;
     buffer.write(dart.dinvokef(onNonMatch, ""));
     while (dart.notNull(i) < dart.notNull(length)) {
       buffer.write(dart.dinvokef(onMatch, new StringMatch(i, dart.as(receiver, core.String), "")));
       let code = dart.as(dart.dinvoke(receiver, 'codeUnitAt', i), core.int);
       if ((dart.notNull(code) & ~1023) == 55296 && dart.notNull(length) > dart.notNull(i) + 1) {
         code = dart.as(dart.dinvoke(receiver, 'codeUnitAt', dart.notNull(i) + 1), core.int);
         if ((dart.notNull(code) & ~1023) == 56320) {
           buffer.write(dart.dinvokef(onNonMatch, dart.dinvoke(receiver, 'substring', i, dart.notNull(i) + 2)));
-          i = 2;
+          i = dart.notNull(i) + 2;
           continue;
         }
       }
       buffer.write(dart.dinvokef(onNonMatch, dart.dindex(receiver, i)));
       i = dart.notNull(i) + 1;
     }
     buffer.write(dart.dinvokef(onMatch, new StringMatch(i, dart.as(receiver, core.String), "")));
     buffer.write(dart.dinvokef(onNonMatch, ""));
     return buffer.toString();
   }
@@ skipping 700 matching lines @@
     }
     get isGetterStub() {
       return !!this.jsFunction.$getterStub;
     }
     invokeOn(victim, arguments$) {
       let receiver = victim;
       if (!dart.notNull(this.isIntercepted)) {
         if (!dart.is(arguments$, _interceptors.JSArray))
           arguments$ = new core.List.from(arguments$);
       } else {
-        arguments$ = new core.List.from([victim]);
-        arguments$[core.$addAll](arguments$);
+        let _$ = new core.List.from([victim]);
+        _$[core.$addAll](arguments$);
+        arguments$ = _$;
         if (this.cachedInterceptor != null)
           receiver = this.cachedInterceptor;
       }
       return this.jsFunction.apply(receiver, arguments$);
     }
   }
   class CachedCatchAllInvocation extends CachedInvocation {
     CachedCatchAllInvocation(name, jsFunction, isIntercepted, cachedInterceptor) {
       this.info = new ReflectionInfo(jsFunction);
       super.CachedInvocation(name, jsFunction, isIntercepted, cachedInterceptor);
     }
     get isGetterStub() {
       return false;
     }
     invokeOn(victim, arguments$) {
       let receiver = victim;
       let providedArgumentCount = null;
       let fullParameterCount = dart.notNull(this.info.requiredParameterCount) + dart.notNull(this.info.optionalParameterCount);
       if (!dart.notNull(this.isIntercepted)) {
         if (dart.is(arguments$, _interceptors.JSArray)) {
           providedArgumentCount = arguments$[core.$length];
           if (dart.notNull(providedArgumentCount) < dart.notNull(fullParameterCount)) {
             arguments$ = new core.List.from(arguments$);
           }
         } else {
           arguments$ = new core.List.from(arguments$);
           providedArgumentCount = arguments$[core.$length];
         }
       } else {
-        arguments$ = new core.List.from([victim]);
-        arguments$[core.$addAll](arguments$);
+        let _$ = new core.List.from([victim]);
+        _$[core.$addAll](arguments$);
+        arguments$ = _$;
         if (this.cachedInterceptor != null)
           receiver = this.cachedInterceptor;
         providedArgumentCount = dart.notNull(arguments$[core.$length]) - 1;
       }
       if (dart.notNull(this.info.areOptionalParametersNamed) && dart.notNull(providedArgumentCount) > dart.notNull(this.info.requiredParameterCount)) {
         throw new UnimplementedNoSuchMethodError(`Invocation of unstubbed method '${this.info.reflectionName}'` + ` with ${arguments$[core.$length]} arguments.`);
       } else if (dart.notNull(providedArgumentCount) < dart.notNull(this.info.requiredParameterCount)) {
         throw new UnimplementedNoSuchMethodError(`Invocation of unstubbed method '${this.info.reflectionName}'` + ` with ${providedArgumentCount} arguments (too few).`);
       } else if (dart.notNull(providedArgumentCount) > dart.notNull(fullParameterCount)) {
         throw new UnimplementedNoSuchMethodError(`Invocation of unstubbed method '${this.info.reflectionName}'` + ` with ${providedArgumentCount} arguments (too many).`);
@@ skipping 86 matching lines @@
     }
     sortedIndex(unsortedIndex) {
       if (this.cachedSortedIndices == null) {
         this.cachedSortedIndices = new core.List(this.optionalParameterCount);
         let positions = dart.map();
         for (let i = 0; dart.notNull(i) < dart.notNull(this.optionalParameterCount); i = dart.notNull(i) + 1) {
           let index = dart.notNull(this.requiredParameterCount) + dart.notNull(i);
           positions.set(this.parameterName(index), index);
         }
         let index = 0;
-        ((_$) => {
-          _$[core.$sort]();
-          return _$;
-        })(positions.keys[core.$toList]())[core.$forEach](((name) => {
-          this.cachedSortedIndices[core.$set](((x$) => index = dart.notNull(x$) + 1, x$)(index), positions.get(name));
+        ((_$) => (_$ = positions.keys[core.$toList](), _$[core.$sort](), _$))()[core.$forEach](((name) => {
+          this.cachedSortedIndices[core.$set](((x$) => (x$ = index, index = dart.notNull(x$) + 1, x$))(), positions.get(name));
         }).bind(this));
       }
       return dart.as(this.cachedSortedIndices[core.$get](unsortedIndex), core.int);
     }
     computeFunctionRti(jsConstructor) {
       if (typeof this.functionType == "number") {
         return getMetadata(dart.as(this.functionType, core.int));
       } else if (typeof this.functionType == "function") {
         let fakeInstance = new jsConstructor();
         setRuntimeTypeInfo(fakeInstance, fakeInstance["<>"]);
@@ skipping 14 matching lines @@
   // Function getMetadata: (int) → dynamic
   function getMetadata(index) {
     let metadata = _foreign_helper.JS_EMBEDDED_GLOBAL('', _js_embedded_names.METADATA);
     return metadata[index];
   }
   let _throwFormatException = Symbol('_throwFormatException');
   let _fromCharCodeApply = Symbol('_fromCharCodeApply');
   let _mangledNameMatchesType = Symbol('_mangledNameMatchesType');
   class Primitives extends core.Object {
     static initializeStatics(id) {
-      Primitives.mirrorFunctionCacheName = `_${id}`;
-      Primitives.mirrorInvokeCacheName = `_${id}`;
+      Primitives.mirrorFunctionCacheName = core.String['+'](Primitives.mirrorFunctionCacheName, `_${id}`);
+      Primitives.mirrorInvokeCacheName = core.String['+'](Primitives.mirrorInvokeCacheName, `_${id}`);
     }
     static objectHashCode(object) {
       let hash = dart.as(object.$identityHash, core.int);
       if (hash == null) {
         hash = Math.random() * 0x3fffffff | 0;
         object.$identityHash = hash;
       }
       return hash;
     }
     static [_throwFormatException](string) {
@@ skipping 118 matching lines @@
       requiresPreamble();
       if (!!self.location) {
         return self.location.href;
       }
       return null;
     }
     static [_fromCharCodeApply](array) {
       let result = "";
       let kMaxApply = 500;
       let end = array[core.$length];
-      for (let i = 0; dart.notNull(i) < dart.notNull(end); i = kMaxApply) {
+      for (let i = 0; dart.notNull(i) < dart.notNull(end); i = dart.notNull(i) + dart.notNull(kMaxApply)) {
         let subarray = null;
         if (dart.notNull(end) <= dart.notNull(kMaxApply)) {
           subarray = array;
         } else {
           subarray = array.slice(i, dart.notNull(i) + dart.notNull(kMaxApply) < dart.notNull(end) ? dart.notNull(i) + dart.notNull(kMaxApply) : end);
         }
         result = result + String.fromCharCode.apply(null, subarray);
       }
       return result;
     }
@@ skipping 142 matching lines @@
       if (dart.notNull(object == null) || dart.notNull(typeof object == 'boolean') || dart.notNull(dart.is(object, core.num)) || dart.notNull(typeof object == 'string')) {
         throw new core.ArgumentError(object);
       }
       object[key] = value;
     }
     static functionNoSuchMethod(func, positionalArguments, namedArguments) {
       let argumentCount = 0;
       let arguments$ = new core.List.from([]);
       let namedArgumentList = new core.List.from([]);
       if (positionalArguments != null) {
-        argumentCount = positionalArguments[core.$length];
+        argumentCount = dart.notNull(argumentCount) + dart.notNull(positionalArguments[core.$length]);
         arguments$[core.$addAll](positionalArguments);
       }
       let names = '';
       if (dart.notNull(namedArguments != null) && !dart.notNull(namedArguments.isEmpty)) {
         namedArguments.forEach((name, argument) => {
           names = `${names}$${name}`;
           namedArgumentList[core.$add](name);
           arguments$[core.$add](argument);
           argumentCount = dart.notNull(argumentCount) + 1;
         });
@@ skipping 492 matching lines @@
       return dart.as(dart.dload(object, 'hashCode'), core.int);
     } else {
       return Primitives.objectHashCode(object);
     }
   }
   // Function fillLiteralMap: (dynamic, Map<dynamic, dynamic>) → dynamic
   function fillLiteralMap(keyValuePairs, result) {
     let index = 0;
     let length = getLength(keyValuePairs);
     while (dart.notNull(index) < dart.notNull(length)) {
-      let key = getIndex(keyValuePairs, ((x$) => index = dart.notNull(x$) + 1, x$)(index));
-      let value = getIndex(keyValuePairs, ((x$) => index = dart.notNull(x$) + 1, x$)(index));
+      let key = getIndex(keyValuePairs, ((x$) => (x$ = index, index = dart.notNull(x$) + 1, x$))());
+      let value = getIndex(keyValuePairs, ((x$) => (x$ = index, index = dart.notNull(x$) + 1, x$))());
       result.set(key, value);
     }
     return result;
   }
   // Function invokeClosure: (Function, dynamic, int, dynamic, dynamic, dynamic, dynamic) → dynamic
   function invokeClosure(closure, isolate, numberOfArguments, arg1, arg2, arg3, arg4) {
     if (numberOfArguments == 0) {
       return _foreign_helper.JS_CALL_IN_ISOLATE(isolate, () => dart.dinvokef(closure));
     } else if (numberOfArguments == 1) {
       return _foreign_helper.JS_CALL_IN_ISOLATE(isolate, () => dart.dinvokef(closure, arg1));
@@ skipping 35 matching lines @@
       let callName = dart.as(func.$callName, core.String);
       func.$reflectionInfo = reflectionInfo;
       let info = new ReflectionInfo(func);
       let functionType = info.functionType;
       let prototype = isStatic ? Object.create(new TearOffClosure().constructor.prototype) : Object.create(new BoundClosure(null, null, null, null).constructor.prototype);
       prototype.$initialize = prototype.constructor;
       let constructor = isStatic ? function() {
         this.$initialize();
       } : Closure.isCsp ? function(a, b, c, d) {
         this.$initialize(a, b, c, d);
-      } : new Function("a", "b", "c", "d", "this.$initialize(a,b,c,d);" + ((x$) => Closure.functionCounter = dart.notNull(x$) + 1, x$)(Closure.functionCounter));
+      } : new Function("a", "b", "c", "d", "this.$initialize(a,b,c,d);" + ((x$) => (x$ = Closure.functionCounter, Closure.functionCounter = dart.notNull(x$) + 1, x$))());
       prototype.constructor = constructor;
       constructor.prototype = prototype;
       let trampoline = func;
       let isIntercepted = false;
       if (!dart.notNull(isStatic)) {
         if (jsArguments.length == 1) {
           isIntercepted = true;
         }
         trampoline = Closure.forwardCallTo(receiver, func, isIntercepted);
         trampoline.$reflectionInfo = reflectionInfo;
@@ skipping 100 matching lines @@
       if (isIntercepted)
         return Closure.forwardInterceptedCallTo(receiver, func);
       let stubName = dart.as(func.$stubName, core.String);
       let arity = func.length;
       let lookedUpFunction = receiver[stubName];
       let isSuperCall = !dart.notNull(core.identical(func, lookedUpFunction));
       if (dart.notNull(Closure.isCsp) || dart.notNull(isSuperCall) || dart.notNull(arity) >= 27) {
         return Closure.cspForwardCall(arity, isSuperCall, stubName, func);
       }
       if (arity == 0) {
-        return new Function('return function(){' + `return this.${BoundClosure.selfFieldName()}.${stubName}();` + `${((x$) => Closure.functionCounter = dart.notNull(x$) + 1, x$)(Closure.functionCounter)}` + '}')();
+        return new Function('return function(){' + `return this.${BoundClosure.selfFieldName()}.${stubName}();` + `${((x$) => (x$ = Closure.functionCounter, Closure.functionCounter = dart.notNull(x$) + 1, x$))()}` + '}')();
       }
       dart.assert(1 <= dart.notNull(arity) && dart.notNull(arity) < 27);
       let arguments$ = "abcdefghijklmnopqrstuvwxyz".split("").splice(0, arity).join(",");
-      return new Function(`return function(${arguments$}){` + `return this.${BoundClosure.selfFieldName()}.${stubName}(${arguments$});` + `${((x$) => Closure.functionCounter = dart.notNull(x$) + 1, x$)(Closure.functionCounter)}` + '}')();
+      return new Function(`return function(${arguments$}){` + `return this.${BoundClosure.selfFieldName()}.${stubName}(${arguments$});` + `${((x$) => (x$ = Closure.functionCounter, Closure.functionCounter = dart.notNull(x$) + 1, x$))()}` + '}')();
     }
     static cspForwardInterceptedCall(arity, isSuperCall, name, func) {
       let getSelf = _foreign_helper.RAW_DART_FUNCTION_REF(BoundClosure.selfOf);
       let getReceiver = _foreign_helper.RAW_DART_FUNCTION_REF(BoundClosure.receiverOf);
       if (isSuperCall)
         arity = -1;
       switch (arity) {
         case 0:
         {
           throw new RuntimeError('Intercepted function with no arguments.');
@@ skipping 63 matching lines @@
       let receiverField = BoundClosure.receiverFieldName();
       let stubName = dart.as(func.$stubName, core.String);
       let arity = func.length;
       let isCsp = typeof dart_precompiled == "function";
       let lookedUpFunction = receiver[stubName];
       let isSuperCall = !dart.notNull(core.identical(func, lookedUpFunction));
       if (dart.notNull(isCsp) || dart.notNull(isSuperCall) || dart.notNull(arity) >= 28) {
         return Closure.cspForwardInterceptedCall(arity, isSuperCall, stubName, func);
       }
       if (arity == 1) {
-        return new Function('return function(){' + `return this.${selfField}.${stubName}(this.${receiverField});` + `${((x$) => Closure.functionCounter = dart.notNull(x$) + 1, x$)(Closure.functionCounter)}` + '}')();
+        return new Function('return function(){' + `return this.${selfField}.${stubName}(this.${receiverField});` + `${((x$) => (x$ = Closure.functionCounter, Closure.functionCounter = dart.notNull(x$) + 1, x$))()}` + '}')();
       }
       dart.assert(1 < dart.notNull(arity) && dart.notNull(arity) < 28);
       let arguments$ = "abcdefghijklmnopqrstuvwxyz".split("").splice(0, dart.notNull(arity) - 1).join(",");
-      return new Function(`return function(${arguments$}){` + `return this.${selfField}.${stubName}(this.${receiverField}, ${arguments$});` + `${((x$) => Closure.functionCounter = dart.notNull(x$) + 1, x$)(Closure.functionCounter)}` + '}')();
+      return new Function(`return function(${arguments$}){` + `return this.${selfField}.${stubName}(this.${receiverField}, ${arguments$});` + `${((x$) => (x$ = Closure.functionCounter, Closure.functionCounter = dart.notNull(x$) + 1, x$))()}` + '}')();
     }
     toString() {
       return "Closure";
     }
   }
   Closure[dart.implements] = () => [core.Function];
   Closure.FUNCTION_INDEX = 0;
   Closure.NAME_INDEX = 1;
   Closure.CALL_NAME_INDEX = 2;
   Closure.REQUIRED_PARAMETER_INDEX = 3;
@@ skipping 534 matching lines @@
         result.push(dart.dinvoke(dart.dindex(list, i), 'toRti'));
       }
       return result;
     }
     toString() {
       let result = '(';
       let needsComma = false;
       if (this.parameterTypes != null) {
         for (let i = 0; dart.notNull(i) < dart.notNull(this.parameterTypes[core.$length]); i = dart.notNull(i) + 1) {
           let type = this.parameterTypes[core.$get](i);
-          if (needsComma)
-            result = ', ';
-          result = `${type}`;
+          if (needsComma) {
+            result = core.String['+'](result, ', ');
+          }
+          result = core.String['+'](result, `${type}`);
           needsComma = true;
         }
       }
       if (dart.notNull(this.optionalParameterTypes != null) && !dart.notNull(this.optionalParameterTypes[core.$isEmpty])) {
-        if (needsComma)
-          result = ', ';
+        if (needsComma) {
+          result = core.String['+'](result, ', ');
+        }
         needsComma = false;
-        result = '[';
+        result = core.String['+'](result, '[');
         for (let i = 0; dart.notNull(i) < dart.notNull(this.optionalParameterTypes[core.$length]); i = dart.notNull(i) + 1) {
           let type = this.optionalParameterTypes[core.$get](i);
-          if (needsComma)
-            result = ', ';
-          result = `${type}`;
+          if (needsComma) {
+            result = core.String['+'](result, ', ');
+          }
+          result = core.String['+'](result, `${type}`);
           needsComma = true;
         }
-        result = ']';
+        result = core.String['+'](result, ']');
       } else if (this.namedParameters != null) {
-        if (needsComma)
-          result = ', ';
+        if (needsComma) {
+          result = core.String['+'](result, ', ');
+        }
         needsComma = false;
-        result = '{';
+        result = core.String['+'](result, '{');
         let keys = _js_names.extractKeys(this.namedParameters);
         for (let i = 0; dart.notNull(i) < dart.notNull(keys[core.$length]); i = dart.notNull(i) + 1) {
           let name = keys[core.$get](i);
-          if (needsComma)
-            result = ', ';
+          if (needsComma) {
+            result = core.String['+'](result, ', ');
+          }
           let rti = dart.dinvoke(this.namedParameters[name], 'toRti');
-          result = `${rti} ${name}`;
+          result = core.String['+'](result, `${rti} ${name}`);
           needsComma = true;
         }
-        result = '}';
+        result = core.String['+'](result, '}');
       }
-      result = `) -> ${this.returnType}`;
+      result = core.String['+'](result, `) -> ${this.returnType}`);
       return result;
     }
   }
   RuntimeFunctionType.inAssert = false;
   // Function buildFunctionType: (dynamic, dynamic, dynamic) → RuntimeFunctionType
   function buildFunctionType(returnType, parameterTypes, optionalParameterTypes) {
     return new RuntimeFunctionType(dart.as(returnType, RuntimeType), dart.as(parameterTypes, core.List$(RuntimeType)), dart.as(optionalParameterTypes, core.List$(RuntimeType)), null);
   }
   // Function buildNamedFunctionType: (dynamic, dynamic, dynamic) → RuntimeFunctionType
   function buildNamedFunctionType(returnType, parameterTypes, namedParameters) {
@@ skipping 171 matching lines @@
         throw 'bad type';
       }
     }
     toString() {
       if (this[_cachedToString] != null)
         return this[_cachedToString];
       let s = "(";
       let sep = '';
       if (this[_hasArguments]) {
         for (let argument of this[_arguments]) {
-          s = sep;
-          s = this[_convert](argument);
+          s = core.String['+'](s, sep);
+          s = core.String['+'](s, this[_convert](argument));
           sep = ', ';
         }
       }
       if (this[_hasOptionalArguments]) {
-        s = `${sep}[`;
+        s = core.String['+'](s, `${sep}[`);
         sep = '';
         for (let argument of this[_optionalArguments]) {
-          s = sep;
-          s = this[_convert](argument);
+          s = core.String['+'](s, sep);
+          s = core.String['+'](s, this[_convert](argument));
           sep = ', ';
         }
-        s = ']';
+        s = core.String['+'](s, ']');
       }
       if (this[_hasNamedArguments]) {
-        s = `${sep}{`;
+        s = core.String['+'](s, `${sep}{`);
         sep = '';
         for (let name of _js_names.extractKeys(this[_namedArguments])) {
-          s = sep;
-          s = `${name}: `;
-          s = this[_convert](this[_namedArguments][name]);
+          s = core.String['+'](s, sep);
+          s = core.String['+'](s, `${name}: `);
+          s = core.String['+'](s, this[_convert](this[_namedArguments][name]));
           sep = ', ';
         }
-        s = '}';
+        s = core.String['+'](s, '}');
       }
-      s = ') -> ';
+      s = core.String['+'](s, ') -> ');
       if (this[_isVoid]) {
-        s = 'void';
+        s = core.String['+'](s, 'void');
       } else if (this[_hasReturnType]) {
-        s = this[_convert](this[_returnType]);
+        s = core.String['+'](s, this[_convert](this[_returnType]));
       } else {
-        s = 'dynamic';
+        s = core.String['+'](s, 'dynamic');
       }
       return this[_cachedToString] = `${s}`;
     }
   }
   class UnimplementedNoSuchMethodError extends core.Error {
     UnimplementedNoSuchMethodError(message$) {
       this[_message] = message$;
       super.Error();
     }
     toString() {
@@ skipping 372 matching lines @@
   exports.jsonEncodeNative = jsonEncodeNative;
   exports.getIsolateAffinityTag = getIsolateAffinityTag;
   exports.LoadLibraryFunctionType = LoadLibraryFunctionType;
   exports.DeferredLoadCallback = DeferredLoadCallback;
   exports.loadDeferredLibrary = loadDeferredLibrary;
   exports.MainError = MainError;
   exports.missingMain = missingMain;
   exports.badMain = badMain;
   exports.mainHasTooManyParameters = mainHasTooManyParameters;
 })(_js_helper || (_js_helper = {}));