Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: third_party/libexif/libexif.gyp

Issue 1069433002: Don't #define snprintf in VS 2015 builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix snprintf definition for libexif also. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/content_shell.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 ['OS == "linux" and chromeos==0', { 8 ['OS == "linux" and chromeos==0', {
9 'use_system_libexif%': 1, 9 'use_system_libexif%': 1,
10 }, { # OS != "linux" and chromeos==0 10 }, { # OS != "linux" and chromeos==0
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 ], 76 ],
77 'xcode_settings': { 77 'xcode_settings': {
78 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # no -fvisibility=hidden 78 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # no -fvisibility=hidden
79 }, 79 },
80 }], 80 }],
81 ['OS=="win"', { 81 ['OS=="win"', {
82 'product_name': 'libexif', 82 'product_name': 'libexif',
83 'sources': [ 83 'sources': [
84 'libexif.def', 84 'libexif.def',
85 ], 85 ],
86 'conditions': [
87 ['MSVS_VERSION < "2015"', {
88 'defines': [
89 # This seems like a hack, but this is what Safari Win does.
90 # Luckily it is no longer needed/allowed with VS 2015.
91 'snprintf=_snprintf',
92 ],
93 }],
94 ],
86 'defines': [ 95 'defines': [
87 # This seems like a hack, but this is what WebKit Win does.
88 'snprintf=_snprintf',
89 'inline=__inline', 96 'inline=__inline',
90 ], 97 ],
91 'msvs_disabled_warnings': [ 98 'msvs_disabled_warnings': [
92 4018, # size/unsigned mismatch 99 4018, # size/unsigned mismatch
93 4267, # size_t -> ExifLong truncation on amd64 100 4267, # size_t -> ExifLong truncation on amd64
94 ], 101 ],
95 # As of VS 2013 Update 3, building this project with /analyze hits 102 # As of VS 2013 Update 3, building this project with /analyze hits
96 # an internal compiler error on exif-entry.c. This halts the build 103 # an internal compiler error on exif-entry.c. This halts the build
97 # and prevents subsequent analysis. Therefore, /analyze is 104 # and prevents subsequent analysis. Therefore, /analyze is
98 # disabled for this project. See this bug for details: 105 # disabled for this project. See this bug for details:
(...skipping 29 matching lines...) Expand all
128 ], 135 ],
129 'defines': [ 136 'defines': [
130 'USE_SYSTEM_LIBEXIF', 137 'USE_SYSTEM_LIBEXIF',
131 ], 138 ],
132 }, 139 },
133 } 140 }
134 ], 141 ],
135 }], 142 }],
136 ] 143 ]
137 } 144 }
OLDNEW
« no previous file with comments | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698