src/effects/SkTileImageFilter.cpp - Issue 106943002: Fixed a few places where uninitialized memory could have been read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkTileImageFilter.cpp

Issue 106943002: Fixed a few places where uninitialized memory could have been read (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Removed bad scalar checks in SkColorMatrixFilter.cpp Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkTileImageFilter.cpp

diff --git a/src/effects/SkTileImageFilter.cpp b/src/effects/SkTileImageFilter.cpp

index 7d3b72f0c6200bbd15f428b5bb22f866dc4baccb..c5eace0b74ddd598311af434bb9128cc30437a82 100644

--- a/src/effects/SkTileImageFilter.cpp

+++ b/src/effects/SkTileImageFilter.cpp

@@ -61,7 +61,7 @@ SkTileImageFilter::SkTileImageFilter(SkFlattenableReadBuffer& buffer)

: INHERITED(1, buffer) {

buffer.readRect(&fSrcRect);

buffer.readRect(&fDstRect);

- buffer.validate(SkIsValidRect(fSrcRect) && SkIsValidRect(fDstRect));

+ buffer.validate(buffer.isValid() && SkIsValidRect(fSrcRect) && SkIsValidRect(fDstRect));

}

void SkTileImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {