src/effects/SkMatrixConvolutionImageFilter.cpp - Issue 106943002: Fixed a few places where uninitialized memory could have been read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMatrixConvolutionImageFilter.cpp

Issue 106943002: Fixed a few places where uninitialized memory could have been read (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMatrixConvolutionImageFilter.cpp

diff --git a/src/effects/SkMatrixConvolutionImageFilter.cpp b/src/effects/SkMatrixConvolutionImageFilter.cpp

index 3da27cef26e1b5697d37f094baa5428b44a2ef1c..eeea494fd3f1b7145b125b3d47f20756c7f223f6 100644

--- a/src/effects/SkMatrixConvolutionImageFilter.cpp

+++ b/src/effects/SkMatrixConvolutionImageFilter.cpp

@@ -82,7 +82,8 @@ SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(SkFlattenableRead

fTarget.fY = buffer.readInt();

fTileMode = (TileMode) buffer.readInt();

fConvolveAlpha = buffer.readBool();

- buffer.validate((fKernel != 0) &&

+ buffer.validate(buffer.validate(true) &&

+ (fKernel != 0) &&

SkScalarIsFinite(fGain) &&

SkScalarIsFinite(fBias) &&

tile_mode_is_valid(fTileMode));