Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1069423004: cros: Fix WebviewLoginTest.Basic multiple login attempts. (Closed)

Created:
5 years, 8 months ago by xiyuan
Modified:
5 years, 8 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix WebviewLoginTest.Basic multiple login attempts. ShowSigninScreenForCreds is used to automatically fill-in sign-in forms and submit it. WebviewLoginTest.Basic does that manually thus should not call it. Otherwise, /_/embedded/signin/challenge is called multiple times with wrong email (empty) and could trigger FakeGaia failures. BUG=472095 Committed: https://crrev.com/5a0107a25031f3ad52a5afa15acbb4fac4560d34 Cr-Commit-Position: refs/heads/master@{#324353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/chromeos/login/webview_login_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xiyuan
5 years, 8 months ago (2015-04-08 22:38:46 UTC) #2
Dmitry Polukhin
lgtm
5 years, 8 months ago (2015-04-09 01:56:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069423004/1
5 years, 8 months ago (2015-04-09 02:58:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 03:42:39 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 03:43:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a0107a25031f3ad52a5afa15acbb4fac4560d34
Cr-Commit-Position: refs/heads/master@{#324353}

Powered by Google App Engine
This is Rietveld 408576698