Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: src/ast-value-factory.cc

Issue 1069423003: Remove comparison operator and helper function from AstRawString interface (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast-value-factory.h ('k') | src/modules.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 bool AstRawString::IsOneByteEqualTo(const char* data) const { 107 bool AstRawString::IsOneByteEqualTo(const char* data) const {
108 int length = static_cast<int>(strlen(data)); 108 int length = static_cast<int>(strlen(data));
109 if (is_one_byte_ && literal_bytes_.length() == length) { 109 if (is_one_byte_ && literal_bytes_.length() == length) {
110 const char* token = reinterpret_cast<const char*>(literal_bytes_.start()); 110 const char* token = reinterpret_cast<const char*>(literal_bytes_.start());
111 return !strncmp(token, data, length); 111 return !strncmp(token, data, length);
112 } 112 }
113 return false; 113 return false;
114 } 114 }
115 115
116 116
117 bool AstRawString::Compare(void* a, void* b) {
118 return *static_cast<AstRawString*>(a) == *static_cast<AstRawString*>(b);
119 }
120
121 bool AstRawString::operator==(const AstRawString& rhs) const {
122 if (is_one_byte_ != rhs.is_one_byte_) return false;
123 if (hash_ != rhs.hash_) return false;
124 int len = literal_bytes_.length();
125 if (rhs.literal_bytes_.length() != len) return false;
126 return memcmp(literal_bytes_.start(), rhs.literal_bytes_.start(), len) == 0;
127 }
128
129
130 void AstConsString::Internalize(Isolate* isolate) { 117 void AstConsString::Internalize(Isolate* isolate) {
131 // AstRawStrings are internalized before AstConsStrings so left and right are 118 // AstRawStrings are internalized before AstConsStrings so left and right are
132 // already internalized. 119 // already internalized.
133 string_ = isolate->factory() 120 string_ = isolate->factory()
134 ->NewConsString(left_->string(), right_->string()) 121 ->NewConsString(left_->string(), right_->string())
135 .ToHandleChecked(); 122 .ToHandleChecked();
136 } 123 }
137 124
138 125
139 bool AstValue::IsPropertyName() const { 126 bool AstValue::IsPropertyName() const {
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 strings_.Add(new_string); 362 strings_.Add(new_string);
376 if (isolate_) { 363 if (isolate_) {
377 new_string->Internalize(isolate_); 364 new_string->Internalize(isolate_);
378 } 365 }
379 entry->value = reinterpret_cast<void*>(1); 366 entry->value = reinterpret_cast<void*>(1);
380 } 367 }
381 return reinterpret_cast<AstRawString*>(entry->key); 368 return reinterpret_cast<AstRawString*>(entry->key);
382 } 369 }
383 370
384 371
372 bool AstValueFactory::AstRawStringCompare(void* a, void* b) {
373 const AstRawString* lhs = static_cast<AstRawString*>(a);
374 const AstRawString* rhs = static_cast<AstRawString*>(b);
375 if (lhs->is_one_byte() != rhs->is_one_byte()) return false;
376 if (lhs->hash() != rhs->hash()) return false;
377 int len = lhs->byte_length();
378 if (rhs->byte_length() != len) return false;
379 return memcmp(lhs->raw_data(), rhs->raw_data(), len) == 0;
380 }
385 } } // namespace v8::internal 381 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast-value-factory.h ('k') | src/modules.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698