Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1069413002: Inline ClientSocketPoolManager::GroupTypeFromScheme (Closed)

Created:
5 years, 8 months ago by Ryan Hamilton
Modified:
5 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline ClientSocketPoolManager::GroupTypeFromScheme Committed: https://crrev.com/54dea7dc6a96261555f9be42d648f46e6d709e47 Cr-Commit-Position: refs/heads/master@{#324242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_manager.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ryan Hamilton
5 years, 8 months ago (2015-04-08 14:17:38 UTC) #2
mmenke
LGTM!
5 years, 8 months ago (2015-04-08 14:33:26 UTC) #3
Ryan Hamilton
On 2015/04/08 14:33:26, mmenke wrote: > LGTM! I really appreciate your review of this and ...
5 years, 8 months ago (2015-04-08 15:31:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069413002/1
5 years, 8 months ago (2015-04-08 15:31:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 17:06:15 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 17:07:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54dea7dc6a96261555f9be42d648f46e6d709e47
Cr-Commit-Position: refs/heads/master@{#324242}

Powered by Google App Engine
This is Rietveld 408576698