Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 10694043: Handle gesture events in notifications. (Closed)

Created:
8 years, 5 months ago by stevenjb
Modified:
8 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Handle gesture events in notifications. Also move common code to TrayNotificationView and separate into its own file. BUG=133280 TEST=System notifications should close and spawn detailed views (if appropriate) on click or touch. Web notifications should perform the associated action (if any) on click or touch, e.g. gmail notifications should open gmail. See issue also. For ash.gyp: TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145391

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase + remove extra WS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -178 lines) Patch
M ash/ash.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/ime/tray_ime.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M ash/system/locale/tray_locale.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ash/system/network/tray_network.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M ash/system/network/tray_sms.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M ash/system/power/tray_power.cc View 3 chunks +2 lines, -8 lines 0 comments Download
A ash/system/tray/tray_notification_view.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A ash/system/tray/tray_notification_view.cc View 1 chunk +142 lines, -0 lines 0 comments Download
M ash/system/tray/tray_views.h View 1 chunk +0 lines, -41 lines 0 comments Download
M ash/system/tray/tray_views.cc View 2 chunks +0 lines, -93 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
Ready for review. http://codereview.chromium.org/10694043/diff/1/ash/system/tray/tray_notification_view.cc File ash/system/tray/tray_notification_view.cc (right): http://codereview.chromium.org/10694043/diff/1/ash/system/tray/tray_notification_view.cc#newcode29 ash/system/tray/tray_notification_view.cc:29: void TrayNotificationView::InitView(views::View* contents) { InitView through ...
8 years, 5 months ago (2012-06-29 22:37:02 UTC) #1
sadrul
LGTM http://codereview.chromium.org/10694043/diff/1/ash/system/tray/tray_notification_view.h File ash/system/tray/tray_notification_view.h (right): http://codereview.chromium.org/10694043/diff/1/ash/system/tray/tray_notification_view.h#newcode61 ash/system/tray/tray_notification_view.h:61: remove empty line.
8 years, 5 months ago (2012-07-03 02:27:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10694043/8002
8 years, 5 months ago (2012-07-03 20:52:17 UTC) #3
commit-bot: I haz the power
Presubmit check for 10694043-8002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-03 20:52:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10694043/8002
8 years, 5 months ago (2012-07-03 20:54:23 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 22:08:57 UTC) #6
Change committed as 145391

Powered by Google App Engine
This is Rietveld 408576698