Issue 10694039: Fix to limit SDK text search matches to darty files (dartbug.com/3896).

Issue 10694039: Fix to limit SDK text search matches to darty files (dartbug.com/3896). (Closed)

Created:
8 years, 5 months ago by pquitslund

Modified:
8 years, 5 months ago

Reviewers:
devoncarew, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix to limit SDK text search matches to darty files (dartbug.com/3896). Committed: https://code.google.com/p/dart/source/detail?r=9257

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -14 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java	View	1	3 chunks	+24 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

devoncarew

lgtm http://codereview.chromium.org/10694039/diff/1/editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java File editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java (right): http://codereview.chromium.org/10694039/diff/1/editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java#newcode83 editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java:83: if (fileName.endsWith(".dart.js_")) { While you're in this file, ...

8 years, 5 months ago (2012-06-29 18:16:00 UTC) #2

pquitslund

Thanks! http://codereview.chromium.org/10694039/diff/1/editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java File editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java (right): http://codereview.chromium.org/10694039/diff/1/editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java#newcode83 editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java:83: if (fileName.endsWith(".dart.js_")) { On 2012/06/29 18:16:00, devoncarew wrote: ...

8 years, 5 months ago (2012-06-29 18:17:24 UTC) #3

lgtm

Expand Messages | Collapse Messages