Issue 1069403003: Remove CSS list-style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1069403003: Remove CSS list-style (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove CSS list-style We don't have lists. So they can't be styled. Dead code be dead. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3dee290c0946f1a3a7727e9c08c4c3e2c68d746d

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -557 lines)			Patch
M	sky/engine/core/animation/css/CSSAnimatableValueFactory.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/animation/css/CSSPropertyEquality.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/css/CSSComputedStyleDeclaration.cpp	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/engine/core/css/CSSPrimitiveValueMappings.h	View	1 chunk	+0 lines, -292 lines	0 comments	Download
M	sky/engine/core/css/CSSProperties.in	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	sky/engine/core/css/CSSValueKeywords.in	View	1 chunk	+3 lines, -88 lines	0 comments	Download
M	sky/engine/core/css/StylePropertySerializer.cpp	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	sky/engine/core/css/parser/BisonCSSParser-in.cpp	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSPropertyParser.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleBuilderCustom.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResourceLoader.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyle.h	View	7 chunks	+0 lines, -17 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyle.cpp	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyleConstants.h	View	2 chunks	+0 lines, -87 lines	0 comments	Download
M	sky/engine/core/rendering/style/StyleRareInheritedData.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/style/StyleRareInheritedData.cpp	View	4 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 8 months ago (2015-04-08 22:03:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3dee290c0946f1a3a7727e9c08c4c3e2c68d746d (presubmit successful).

Expand Messages | Collapse Messages