Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: content/common/child_thread.cc

Issue 10694014: Cleanup IPC::ChannelProxy to use SingleThreadTaskRunner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/child_thread.h" 5 #include "content/common/child_thread.h"
6 6
7 #include "base/allocator/allocator_extension.h" 7 #include "base/allocator/allocator_extension.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/process.h" 10 #include "base/process.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 channel_->Close(); 76 channel_->Close();
77 77
78 // The ChannelProxy object caches a pointer to the IPC thread, so need to 78 // The ChannelProxy object caches a pointer to the IPC thread, so need to
79 // reset it as it's not guaranteed to outlive this object. 79 // reset it as it's not guaranteed to outlive this object.
80 // NOTE: this also has the side-effect of not closing the main IPC channel to 80 // NOTE: this also has the side-effect of not closing the main IPC channel to
81 // the browser process. This is needed because this is the signal that the 81 // the browser process. This is needed because this is the signal that the
82 // browser uses to know that this process has died, so we need it to be alive 82 // browser uses to know that this process has died, so we need it to be alive
83 // until this process is shut down, and the OS closes the handle 83 // until this process is shut down, and the OS closes the handle
84 // automatically. We used to watch the object handle on Windows to do this, 84 // automatically. We used to watch the object handle on Windows to do this,
85 // but it wasn't possible to do so on POSIX. 85 // but it wasn't possible to do so on POSIX.
86 channel_->ClearIPCMessageLoop(); 86 channel_->ClearIPCTaskRunner();
87 } 87 }
88 88
89 void ChildThread::OnChannelError() { 89 void ChildThread::OnChannelError() {
90 set_on_channel_error_called(true); 90 set_on_channel_error_called(true);
91 MessageLoop::current()->Quit(); 91 MessageLoop::current()->Quit();
92 } 92 }
93 93
94 bool ChildThread::Send(IPC::Message* msg) { 94 bool ChildThread::Send(IPC::Message* msg) {
95 DCHECK(MessageLoop::current() == message_loop()); 95 DCHECK(MessageLoop::current() == message_loop());
96 if (!channel_.get()) { 96 if (!channel_.get()) {
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 } 276 }
277 277
278 // The child process shutdown sequence is a request response based mechanism, 278 // The child process shutdown sequence is a request response based mechanism,
279 // where we send out an initial feeler request to the child process host 279 // where we send out an initial feeler request to the child process host
280 // instance in the browser to verify if it's ok to shutdown the child process. 280 // instance in the browser to verify if it's ok to shutdown the child process.
281 // The browser then sends back a response if it's ok to shutdown. This avoids 281 // The browser then sends back a response if it's ok to shutdown. This avoids
282 // race conditions if the process refcount is 0 but there's an IPC message 282 // race conditions if the process refcount is 0 but there's an IPC message
283 // inflight that would addref it. 283 // inflight that would addref it.
284 Send(new ChildProcessHostMsg_ShutdownRequest); 284 Send(new ChildProcessHostMsg_ShutdownRequest);
285 } 285 }
OLDNEW
« no previous file with comments | « chrome/service/service_ipc_server.cc ('k') | content/common/indexed_db/indexed_db_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698