Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1069363003: Tests that carefully checks opt/deopt status shouldn't --always-opt. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tests that carefully checks opt/deopt status shouldn't --always-opt. If we optimize a function before gathering feedback it may be peppered with soft deoptimizations. So it can't help but deoptimize. A judicious reading of the code isn't enough to determine what the optimization state should be in the face of such chaotic gyrations. BUG= R=verwaest@chromium.org Committed: https://crrev.com/af293729ad51cbf611584d898733964bf0bec5e4 Cr-Commit-Position: refs/heads/master@{#27671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/mjsunit/double-intrinsics.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/block-let-crankshaft.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Toon, Here is the test fix per our chat, --Michael
5 years, 8 months ago (2015-04-08 15:29:12 UTC) #1
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-08 15:30:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069363003/1
5 years, 8 months ago (2015-04-08 15:31:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 15:56:04 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:56:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af293729ad51cbf611584d898733964bf0bec5e4
Cr-Commit-Position: refs/heads/master@{#27671}

Powered by Google App Engine
This is Rietveld 408576698