Issue 1069363002: Revert of Removed arbitrary 4096 size limit on WebGL canvas backbuffers, Take 3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1069363002: Revert of Removed arbitrary 4096 size limit on WebGL canvas backbuffers, Take 3 (Closed)

Created:
5 years, 8 months ago by Michael Achenbach

Modified:
5 years, 8 months ago

Reviewers:
Ken Russell (switch to Gerrit), bajones

CC:
blink-reviews, krit, dshwang, Dominik Röttsches, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, Justin Novosad, jbroman, danakj, dglazkov+blink, Rik, f(malita), Stephen Chennney, aandrey+blink_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of Removed arbitrary 4096 size limit on WebGL canvas backbuffers, Take 3 (patchset #3 id:40001 of https://codereview.chromium.org/1066643003/) Reason for revert: [Sheriff] Breaks http://build.chromium.org/p/chromium.webkit/builders/GPU%20Win7%20%28NVIDIA%29/builds/37501 With OOM Original issue's description: > Removed arbitrary 4096 size limit on WebGL canvas backbuffers, Take 3 > > Worked out the issue from the previous attempt with not consuming the > out of memory error and verified with synthetic OOM generation. (See > https://codereview.chromium.org/1050043003/) > > BUG=445542 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193315 TBR=kbr@chromium.org,bajones@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193339

Patch Set 1 #

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -90 lines)			Patch
M	Source/core/html/canvas/WebGLRenderingContextBase.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/platform/graphics/gpu/DrawingBuffer.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/platform/graphics/gpu/DrawingBuffer.cpp	View	8 chunks	+10 lines, -88 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

Created Revert of Removed arbitrary 4096 size limit on WebGL canvas backbuffers, Take 3

5 years, 8 months ago (2015-04-08 10:03:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069363002/1

5 years, 8 months ago (2015-04-08 10:03:19 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 10:04:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193339

Expand Messages | Collapse Messages