[sql] Change DoesStuffExist() to work with ScopedErrorIgnorer.

sql/connection_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_file.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/logging.h"
 #include "sql/connection.h"
@@ skipping 158 matching lines @@
 TEST_F(SQLConnectionTest, IsSQLValidTest) {
   ASSERT_TRUE(db().Execute("CREATE TABLE foo (a, b)"));
   ASSERT_TRUE(db().IsSQLValid("SELECT a FROM foo"));
   ASSERT_FALSE(db().IsSQLValid("SELECT no_exist FROM foo"));
 }
 
 TEST_F(SQLConnectionTest, DoesStuffExist) {
   // Test DoesTableExist.
   EXPECT_FALSE(db().DoesTableExist("foo"));
   ASSERT_TRUE(db().Execute("CREATE TABLE foo (a, b)"));
+  ASSERT_TRUE(db().Execute("CREATE INDEX foo_a ON foo (a)"));
   EXPECT_TRUE(db().DoesTableExist("foo"));
-
-  // Should be case sensitive.
-  EXPECT_FALSE(db().DoesTableExist("FOO"));
+  EXPECT_TRUE(db().DoesIndexExist("foo_a"));
 
   // Test DoesColumnExist.
   EXPECT_FALSE(db().DoesColumnExist("foo", "bar"));
   EXPECT_TRUE(db().DoesColumnExist("foo", "a"));
 
   // Testing for a column on a nonexistent table.
   EXPECT_FALSE(db().DoesColumnExist("bar", "b"));
+
+  // Names are not case sensitive.
+  EXPECT_TRUE(db().DoesTableExist("FOO"));
+  EXPECT_TRUE(db().DoesColumnExist("FOO", "A"));
 }
 
 TEST_F(SQLConnectionTest, GetLastInsertRowId) {
   ASSERT_TRUE(db().Execute("CREATE TABLE foo (id INTEGER PRIMARY KEY, value)"));
 
   ASSERT_TRUE(db().Execute("INSERT INTO foo (value) VALUES (12)"));
 
   // Last insert row ID should be valid.
   int64 row = db().GetLastInsertRowId();
   EXPECT_LT(0, row);
@@ skipping 14 matching lines @@
   EXPECT_TRUE(db().BeginTransaction());
 }
 
 // Test the scoped error ignorer by attempting to insert a duplicate
 // value into an index.
 TEST_F(SQLConnectionTest, ScopedIgnoreError) {
   const char* kCreateSql = "CREATE TABLE foo (id INTEGER UNIQUE)";
   ASSERT_TRUE(db().Execute(kCreateSql));
   ASSERT_TRUE(db().Execute("INSERT INTO foo (id) VALUES (12)"));
 
-  sql::ScopedErrorIgnorer ignore_errors;
-  ignore_errors.IgnoreError(SQLITE_CONSTRAINT);
-  ASSERT_FALSE(db().Execute("INSERT INTO foo (id) VALUES (12)"));
-  ASSERT_TRUE(ignore_errors.CheckIgnoredErrors());
+  {
+    sql::ScopedErrorIgnorer ignore_errors;
+    ignore_errors.IgnoreError(SQLITE_CONSTRAINT);
+    ASSERT_FALSE(db().Execute("INSERT INTO foo (id) VALUES (12)"));
+    ASSERT_TRUE(ignore_errors.CheckIgnoredErrors());
+  }
+}
+
+// Test that clients of GetUntrackedStatement() can test corruption-handling
+// with ScopedErrorIgnorer.
+TEST_F(SQLConnectionTest, ScopedIgnoreUntracked) {
+  const char* kCreateSql = "CREATE TABLE foo (id INTEGER UNIQUE)";
+  ASSERT_TRUE(db().Execute(kCreateSql));
+  ASSERT_FALSE(db().DoesTableExist("bar"));
+  ASSERT_TRUE(db().DoesTableExist("foo"));
+  ASSERT_TRUE(db().DoesColumnExist("foo", "id"));
+  db().Close();
+
+  // Corrupt the database so that nothing works, including PRAGMAs.
+  ASSERT_TRUE(sql::test::CorruptSizeInHeader(db_path()));
+
+  {
+    sql::ScopedErrorIgnorer ignore_errors;
+    ignore_errors.IgnoreError(SQLITE_CORRUPT);
+    ASSERT_TRUE(db().Open(db_path()));
+    ASSERT_FALSE(db().DoesTableExist("bar"));
+    ASSERT_FALSE(db().DoesTableExist("foo"));
+    ASSERT_FALSE(db().DoesColumnExist("foo", "id"));
+    ASSERT_TRUE(ignore_errors.CheckIgnoredErrors());
+  }
 }
 
 TEST_F(SQLConnectionTest, ErrorCallback) {
   const char* kCreateSql = "CREATE TABLE foo (id INTEGER UNIQUE)";
   ASSERT_TRUE(db().Execute(kCreateSql));
   ASSERT_TRUE(db().Execute("INSERT INTO foo (id) VALUES (12)"));
 
   int error = SQLITE_OK;
   {
     sql::ScopedErrorCallback sec(
@@ skipping 632 matching lines @@
     EXPECT_LT(1u, messages.size());
     EXPECT_NE(kOk, messages[0]);
     ASSERT_TRUE(ignore_errors.CheckIgnoredErrors());
   }
 
   // TODO(shess): CorruptTableOrIndex could be used to produce a
   // file that would pass the quick check and fail the full check.
 }
 
 }  // namespace