[android] Split top-level scripts and libraries from build/android.

build/android/enable_asserts.py

Index: build/android/enable_asserts.py
diff --git a/build/android/enable_asserts.py b/build/android/enable_asserts.py
new file mode 100755
index 0000000000000000000000000000000000000000..c635f6342927111242233503545c540414da8aa9
--- /dev/null
+++ b/build/android/enable_asserts.py
@@ -0,0 +1,31 @@
+#!/usr/bin/env python

[Satish, 2012/07/06 13:21:36]

newline after this

[bulach, 2012/07/06 13:42:09]

Done.

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Enables dalvik vm asserts in the android device."""

[Satish, 2012/07/06 13:21:36]

Is this functionality used by any of the build tools? If not, seems like
build/android is not the right place. I see there are other run/debug utilities
under build/android and perhaps all of them should move under
build/android/tools etc. so it is clear that build/android is about scripts to
build & run tests?

[bulach, 2012/07/06 13:42:09]

not sure I understood...

build/android is about top-level executable scripts, such as this one... this
functionality used to be in android_commands.py,
http://codereview.chromium.org/10693110/diff/4001/build/android/android_comma...

there was a TODO (in the downstream repo only) to remove such functionality from
the library, which is precisely what this is doing: a thin wrapper on top of the
now pure and reusable pylib.android_commands..

specifically: this is used by developers to tweak the assertion levels in their
device.. the test runners themselves also do that internally, using
android_commands directly..

is this ok?

[Satish, 2012/07/06 13:47:39]

I'm thinking build/android should contain only scripts for building and
running/testing the targets. Scripts like this one (and others such as
'adb_logcat_monitor.py' that already exists) seem like tools which are
infrequently used by individual developers during debugging. My suggestion was
to move them to a subdirectory such as 'tools' so that build/android can be only
about building targets and running/testing them. Would that be ok?

+
+from pylib import android_commands
+import optparse
+import os
+import sys
+
+
+def main(argv):
+  option_parser = optparse.OptionParser()
+  option_parser.add_option('--enable_asserts', dest='set_asserts',
+      action='store_true', default=None,
+      help='Sets the dalvik.vm.enableassertions property to "all"')
+  option_parser.add_option('--disable_asserts', dest='set_asserts',
+      action='store_false', default=None,
+      help='Removes the dalvik.vm.enableassertions property')
+  options, args = option_parser.parse_args(argv)
+
+  commands = android_commands.AndroidCommands()
+  if options.set_asserts != None:
+    if commands.SetJavaAssertsEnabled(options.set_asserts):
+      commands.Reboot(full_reboot=False)
+
+
+if __name__ == '__main__':
+  main(sys.argv)