Issue 1069293002: We can no longer assume that there is only one process during layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1069293002: We can no longer assume that there is only one process during layout tests (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 8 months ago

Reviewers:
Mike West

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

We can no longer assume that there is only one process during layout tests Now that we reuse devtools processes during layout tests, it can happen that there are multiple processes during session history tests. Remove the now spurious NOTREACHED() BUG=474162 R=mkwst@chromium.org Committed: https://crrev.com/1377699f5a2d65470f9c35d5e338491a4def81ef Cr-Commit-Position: refs/heads/master@{#324199}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	content/shell/browser/webkit_test_controller.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069293002/1

5 years, 8 months ago (2015-04-08 07:59:57 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 08:36:35 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1377699f5a2d65470f9c35d5e338491a4def81ef
Cr-Commit-Position: refs/heads/master@{#324199}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages