Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1069283002: X87: JSEntryTrampoline: check for stack space before pushing arguments (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: JSEntryTrampoline: check for stack space before pushing arguments port 146598f44a1efd0f942745abfd6c08a073972c01 (r27614) original commit message: Optimistically pushing a lot of arguments can run into the stack limit of the process, at least on operating systems where this limit is close to the limit that V8 sets for itself. BUG= Committed: https://crrev.com/c8521794ba9ddb1e80c5dbe9dcdc6ee572b21445 Cr-Commit-Position: refs/heads/master@{#27684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -34 lines) Patch
M src/x87/builtins-x87.cc View 5 chunks +51 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-09 01:30:17 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-09 04:40:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069283002/1
5 years, 8 months ago (2015-04-09 04:41:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 06:52:04 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 06:52:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8521794ba9ddb1e80c5dbe9dcdc6ee572b21445
Cr-Commit-Position: refs/heads/master@{#27684}

Powered by Google App Engine
This is Rietveld 408576698