Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: media/base/pipeline.cc

Issue 1069253004: Fix MSE playback regression by not changing pipeline duration at EOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/pipeline_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.cc
diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc
index d1fae012cbff286c45aa0d218b2d06e12db7f296..aaa6cb6e8ed7546e5db552f0cb676287ffea734c 100644
--- a/media/base/pipeline.cc
+++ b/media/base/pipeline.cc
@@ -653,16 +653,6 @@ void Pipeline::RunEndedCallbackIfNeeded() {
if (text_renderer_ && text_renderer_->HasTracks() && !text_renderer_ended_)
return;
- // Correct the duration against current time if it turns out that
- // the initially reported duration is wrong
- // TODO(sriram): There are cases where duration is correct and current time
- // falls short of duration by a few milliseconds. This is a workaround
- // till we find the actual fix and 250ms is chosen here as it is
- // the max time between timeupdate events (http://crbug.com/438581).
- TimeDelta media_time = renderer_->GetMediaTime();
- if ((duration_ - media_time).InMilliseconds() > 250)
- SetDuration(media_time);
-
DCHECK_EQ(status_, PIPELINE_OK);
ended_cb_.Run();
}
« no previous file with comments | « no previous file | media/base/pipeline_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698